V3 / ethers preview #1363
Merged
V3 / ethers preview #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
glitch-txs
reviewed
Oct 19, 2023
glitch-txs
previously approved these changes
Oct 19, 2023
xzilja
suggested changes
Oct 20, 2023
glitch-txs
approved these changes
Oct 20, 2023
xzilja
approved these changes
Oct 20, 2023
|
High level thought: There's very little ethers5-specific code here. Have you considered defining a minimal web3 provider interface that someone can implement to create wrappers for any provider? For example, what about supporting ethers6? |
|
Hi @shazow we are planning to add support for v6 as well, were currently figuring out the best approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ethers-5packageWalletConnectProviderInjectedProviderCoinbaseProviderEIP6963Providerutilspackage to store sharedconstants,presetsandhelpersscaffold-reactpackage to store shared react hooksscaffold-vuepackage to store shared vue compositions