Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/error hook ethers #1570

Merged
merged 10 commits into from
Dec 15, 2023
Merged

Chore/error hook ethers #1570

merged 10 commits into from
Dec 15, 2023

Conversation

svenvoskamp
Copy link
Contributor

@svenvoskamp svenvoskamp commented Dec 14, 2023

Changes

Added new useWeb3ModalError hook/composition for ethers and ethers5 package to get internal errors

Associated Issues

closes #1490

Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Dec 14, 2023 2:36pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Dec 14, 2023 2:36pm
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Dec 14, 2023 2:36pm
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Dec 14, 2023 2:36pm

@enesozturk
Copy link
Contributor

@svenvoskamp Do you think it would be beneficial to implement similar error handlings for wagmi as well?

@svenvoskamp
Copy link
Contributor Author

svenvoskamp commented Dec 14, 2023

I don't think we need them, because I think wagmi handles this already internally. https://wagmi.sh/react/hooks/useConnect this hook exports error for example

Copy link
Contributor

@enesozturk enesozturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@svenvoskamp svenvoskamp merged commit 4959d48 into V3 Dec 15, 2023
11 checks passed
@svenvoskamp svenvoskamp deleted the chore/error-hook-ethers branch December 15, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] - Add error handler for connection errors (ethers)
2 participants