Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.6.0-alpha.0 #1577

Merged
merged 24 commits into from
Dec 15, 2023
Merged

3.6.0-alpha.0 #1577

merged 24 commits into from
Dec 15, 2023

Conversation

xzilja
Copy link
Contributor

@xzilja xzilja commented Dec 15, 2023 •
edited
Loading

Breaking Changes

N/A

Changes

  • feat: Email resend functionality
  • feat: Email "send action" throttling of 30s
  • feat: Add and pass initial chain selection when connecting via email
  • chore: Add custom logic / workaround to improve initial loading time when email login was not used beforehand
  • chore: Handle ZodError format
  • chore: Handle email iframe sdk loading error
  • fix: Size issues when overlaying iframe "approve tx" view over modal
  • chore: Various small ui updates to align with figma for email views
  • feat: Add ui changes when only email connector is enabled
  • feat: Add "Upgrade Wallet" view
  • chore: Further build improvements, separating build:clean command from build
  • chore: Update dependencies

Associated Issues

closes #...

@vercel Vercel
Copy link

vercel bot commented Dec 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Dec 15, 2023 1:34pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Dec 15, 2023 1:34pm
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Dec 15, 2023 1:34pm
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Dec 15, 2023 1:34pm

tomiir
tomiir approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@tomiir tomiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some minor comments / questions

package.json Show resolved Hide resolved
packages/scaffold/src/views/w3m-account-view/index.ts Show resolved Hide resolved
enesozturk
enesozturk approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@enesozturk enesozturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, left a few comments 🚀

@xzilja xzilja merged commit cddb123 into V3 Dec 15, 2023
11 checks passed
@xzilja xzilja deleted the email-login/alpha.1 branch December 15, 2023 14:20
svenvoskamp
svenvoskamp reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@svenvoskamp svenvoskamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenvoskamp svenvoskamp svenvoskamp left review comments

@enesozturk enesozturk enesozturk approved these changes

@tomiir tomiir tomiir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xzilja @tomiir @enesozturk @svenvoskamp