Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui-tests): cover sign #1647

Merged
merged 6 commits into from
Dec 22, 2023
Merged

chore(ui-tests): cover sign #1647

merged 6 commits into from
Dec 22, 2023

Conversation

arein
Copy link
Contributor

@arein arein commented Dec 21, 2023

Changes

  • chore(ui-tests): cover sign

@chris13524 @tomiir apologies I decided to expand this PR a bit to actually introduce more coverage.

Copy link

vercel bot commented Dec 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Dec 22, 2023 11:24am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Dec 22, 2023 11:24am
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Dec 22, 2023 11:24am
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Dec 22, 2023 11:24am

tomiir
tomiir previously approved these changes Dec 22, 2023
Copy link
Collaborator

@tomiir tomiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥
Just thinking ahead but would be nice to have some kind of rules for test-id names in the future.

chris13524
chris13524 previously approved these changes Dec 22, 2023
apps/laboratory/tests/basic-tests.spec.ts Show resolved Hide resolved
Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants