feat(ui-test): cover reject signing #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tomiir
approved these changes
Dec 28, 2023
chris13524
approved these changes
Dec 28, 2023
| @@ -13,6 +14,12 @@ export class ModalValidator { | |||
| } | |||
|
|
|||
| async expectAcceptedSign() { | |||
| await expect(this.page.getByText('Success')).toBeVisible() | |||
| // We use Chakra Toast and it's not quite straightforward to set the `data-testid` attribute on the toast element. | |||
There was a problem hiding this comment.
If you can select by css class or another element pattern that would work too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were covering successful signing. This now also covers the wallet rejecting the sign request.
Changes
Associated Issues
closes #...