Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/wallet locked issue #1698

Closed
wants to merge 4 commits into from
Closed

Fix/wallet locked issue #1698

wants to merge 4 commits into from

Conversation

svenvoskamp
Copy link
Contributor

Changes

  • fix: Fix wallet locked autoconnect issue

@vercel Vercel
Copy link

vercel bot commented Jan 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Jan 3, 2024 3:10pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Jan 3, 2024 3:10pm
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Jan 3, 2024 3:10pm
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Jan 3, 2024 3:10pm

tomiir
tomiir reviewed Jan 3, 2024
View reviewed changes
packages/wagmi/src/connectors/EIP6963Connector.ts
Comment on lines +80 to +81
(eip6963Wallet && eip6963Wallet.provider._state?.isUnlocked === undefined) ||
(eip6963Wallet && eip6963Wallet.provider._state?.isUnlocked)
Copy link
Collaborator

@tomiir tomiir Jan 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it be the same to check
if (eip6963Wallet && eip6963Wallet.provider?._state?.isUnlocked === true) { return true }

glitch-txs
glitch-txs reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@glitch-txs glitch-txs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a standard and some wallets might not have it, let's rather check for eth_account which should return an empty array when locked or disconnected.

@tomiir tomiir mentioned this pull request Jan 3, 2024
Merged
@svenvoskamp svenvoskamp closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glitch-txs glitch-txs glitch-txs left review comments

@tomiir tomiir tomiir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svenvoskamp @tomiir @glitch-txs