feat: add loading state to useWeb3ModalState hook #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@boidushya we'd need some docs update on this right? |
yep! This relevant to React, Next & JS right? I'll go ahead and open a PR. |
enesozturk
force-pushed
the
refactor/loading-state-in-useweb3modalstate-hook
branch
from
f3a8420 to
745b668
Compare
enesozturk
force-pushed
the
refactor/loading-state-in-useweb3modalstate-hook
branch
from
745b668 to
4835511
Compare
|
@tomiir @svenvoskamp @ignaciosantise I think not it's handling loading better. Could you review it again? |
tomiir
approved these changes
Mar 26, 2024
ignaciosantise
approved these changes
Mar 26, 2024
|
Can we add a small description on what this state is tracking? It's not 100% clear to me |
enesozturk
force-pushed
the
refactor/loading-state-in-useweb3modalstate-hook
branch
from
5986bfb to
f018d16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
We are storing the
loadingstate inside our scaffold which is managed inPublicStateControllerto make conditional renderings in UI depending on the client's (ethers/wagmi) loading statuses. Whileopen/closestates are exposed to hooks for developers, thisloadingstate not exposed.This PR introduces changes to share the
loadingstate to the hooks.Changes
loadingstate touseWeb3ModalStatehook