Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: safari ci #1923

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ui_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ jobs:
if: steps.playwright-cache.outputs.cache-hit != 'true'
working-directory: ./apps/laboratory/
run: npm run playwright:install
- name: Install Playwright Browser Dependencies
working-directory: ./apps/laboratory/
run: npx playwright install-deps
- name: Run Playwright tests
env:
BASE_URL: ${{ inputs.base-url }}
Expand Down
4 changes: 2 additions & 2 deletions apps/laboratory/playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import { BASE_URL } from './tests/shared/constants'

import { config } from 'dotenv'
import type { ModalFixture } from './tests/shared/fixtures/w3m-fixture'
import { getAvailableDevices } from './tests/shared/utils/device'
import { DEVICES } from './tests/shared/constants/devices'
config({ path: './.env' })
const availableDevices = getAvailableDevices()
const availableDevices = DEVICES

const LIBRARIES = ['wagmi', 'ethers'] as const
const PERMUTATIONS = availableDevices.flatMap(device =>
Expand Down
8 changes: 6 additions & 2 deletions apps/laboratory/tests/shared/pages/WalletPage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ export class WalletPage {
const variant = opts.accept ? `approve` : `reject`
// `.click` doesn't work here, so we use `.focus` and `Space`
const btn = this.page.getByTestId(`session-${variant}-button`)
await btn.waitFor()
await btn.waitFor({
state: 'visible'
})
await expect(btn).toBeEnabled()
await btn.focus()
await this.page.keyboard.press('Space')
Expand All @@ -51,7 +53,9 @@ export class WalletPage {
const variant = accept ? `approve` : `reject`
// `.click` doesn't work here, so we use `.focus` and `Space`
const btn = this.page.getByTestId(`session-${variant}-button`)
await btn.waitFor()
await btn.waitFor({
state: 'visible'
})
await expect(btn).toBeEnabled()
await btn.focus()
await this.page.keyboard.press('Space')
Expand Down
Loading