Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: various email issues from w3i testing #1933

Merged
merged 14 commits into from
Feb 19, 2024
Merged

fix: various email issues from w3i testing #1933

merged 14 commits into from
Feb 19, 2024

Conversation

svenvoskamp
Copy link
Contributor

Changes

  • Fix: In the signing message modal, the message area is not toggling when clicking on it. So only a small part of the message
  • Fix: When rejecting the device approving does nothing on w3m
  • Fix: When typing the wrong code, need to remove the first character to paste another code
  • Fix: Changing email address results in a back button that doesn't do anything
  • Fix: Bad error styling on OTP view

Associated Issues

closes #...

@vercel Vercel
Copy link

vercel bot commented Feb 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Feb 19, 2024 0:54am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Feb 19, 2024 0:54am
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Feb 19, 2024 0:54am
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Feb 19, 2024 0:54am

@svenvoskamp svenvoskamp marked this pull request as ready for review February 19, 2024 11:28
xzilja
xzilja previously approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@xzilja xzilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left small suggestion

packages/core/src/controllers/RouterController.ts Outdated Show resolved Hide resolved
@svenvoskamp svenvoskamp requested a review from xzilja February 19, 2024 13:48
@svenvoskamp svenvoskamp merged commit 033bbf1 into V4 Feb 19, 2024
13 checks passed
@svenvoskamp svenvoskamp deleted the fix/email-w3i-issues branch February 19, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomiir tomiir tomiir approved these changes

@xzilja xzilja xzilja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svenvoskamp @xzilja @tomiir