Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: better handling for rpc request #1958

Merged
merged 12 commits into from
Feb 22, 2024
Merged

hotfix: better handling for rpc request #1958

merged 12 commits into from
Feb 22, 2024

Conversation

svenvoskamp
Copy link
Contributor

@svenvoskamp svenvoskamp commented Feb 22, 2024

Changes

fix: add multiple rpc methods to safe list for auto approval, so users don't end up with blank screen
fix: if rpc method is not handled by our frame provider, we show an error message. Request is automatically rejected
fix: rpc request will be rejected when you close the modal
chore: bump version to 4.0.9

@svenvoskamp svenvoskamp requested a review from tomiir February 22, 2024 10:31
Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Feb 22, 2024 10:59am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Feb 22, 2024 10:59am
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Feb 22, 2024 10:59am
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Feb 22, 2024 10:59am

arein
arein previously approved these changes Feb 22, 2024
Copy link
Contributor

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but nitpick: I'd call it a hotfix because there are not tests in this PR.
Given the priority that's right - but maybe a test in the follow up PR

packages/ethers/src/client.ts Outdated Show resolved Hide resolved
@svenvoskamp svenvoskamp merged commit f6c81f6 into V4 Feb 22, 2024
13 checks passed
@svenvoskamp svenvoskamp deleted the fix/add-rpc-methods branch February 22, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants