:feat new account page + receive flow #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…odal into feat/wallet-features
svenvoskamp
changed the title
tomiir
requested changes
Mar 1, 2024
packages/scaffold/src/partials/w3m-account-default-widget/index.ts
Outdated
Show resolved
Hide resolved
packages/scaffold/src/partials/w3m-account-wallet-features-widget/index.ts
Outdated
Show resolved
Hide resolved
packages/scaffold/src/partials/w3m-account-wallet-features-widget/index.ts
Show resolved
Hide resolved
Comment on lines
+28
to
+29
| const isSmall = | ||
| this.variant === 'success' || this.variant === 'transparent' || this.variant === 'shadeSmall' |
There was a problem hiding this comment.
just wondering if it would be better to have a small prop or even having a textVariant prop directly
tomiir
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
enableWalletFeaturesflag to web3modal optionswui-profile-buttoncomponentwui-promocomponentwui-balancecomponentwui-tooltip-selectcomponentwui-bannercomponentwui-compatible-networkcomponentw3m-receive-vieww3m-compatible-networks-viewTest the flow on
/ethers-walletor/wagmi-walletand use email login.