Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-legacy: Featured wallets filtering out non annoounced connectors #2909

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Sep 23, 2024

Description

  • Non-announced connectors were being filtered for featured wallets

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections

Copy link

changeset-bot bot commented Sep 23, 2024

⚠️ No Changeset found

Latest commit: e3919a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview Sep 27, 2024 6:03pm
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 27, 2024 6:03pm

Copy link
Contributor

github-actions bot commented Sep 23, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 88.24000000000001% 3383 / 13797
🔵 Statements 88.24000000000001% 3383 / 13797
🔵 Functions 165.37% 251 / 743
🔵 Branches 216.54% 470 / 899
File CoverageNo changed files found.
Generated in workflow #6435

Copy link
Contributor

github-actions bot commented Sep 23, 2024

Warnings
⚠️ Changes were made to one or more package.json(s), but not to pnpm-lock.yaml

Generated by 🚫 dangerJS against e3919a5

Copy link
Contributor

github-actions bot commented Sep 23, 2024

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-BN5lApMt.js 1607.231 465.984
assets/noble-curves.js 31.941 12.78
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index.js 9.517 3.191
assets/index2.js 102.248 29.112
assets/index3.js 304.387 87.28
assets/walletconnect-ethereum-provider.js 454.329 141.408
assets/index4.js 11.601 3.207
assets/w3m-modal.js 6.988 2.505
assets/index5.js 12.673 4.695
assets/hooks.module.js 74.437 25.582
assets/walletconnect-modal-ui.js 112.43 34.327
index.html 0.329 0.237
Total Size 2730.9 811.635

Base Size

Name Size (kb) Gzip (kb)
assets/index-BN5lApMt.js 1607.231 465.984
assets/noble-curves.js 31.941 12.78
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index.js 9.517 3.191
assets/index2.js 102.248 29.112
assets/index3.js 304.387 87.28
assets/walletconnect-ethereum-provider.js 454.329 141.408
assets/index4.js 11.601 3.207
assets/w3m-modal.js 6.988 2.505
assets/index5.js 12.673 4.695
assets/hooks.module.js 74.437 25.582
assets/walletconnect-modal-ui.js 112.43 34.327
index.html 0.329 0.237
Total Size 2730.9 811.635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants