chore: allow unsufficient funds for smart accounts swaps

[tomiir]

Description

• Smart Accounts can make use of Paymasters to pay for the gas fees. They should not be stopped on the swap flow as the gas validation is done wallet side with a different algorithm to consider this case.

Type of change

• Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• Code in this PR is covered by automated tests (Unit tests, E2E tests)
• My changes generate no new warnings
• I have reviewed my own code
• I have filled out all required sections
• I have tested my changes on the preview link
• Approver of this PR confirms that the changes are tested on the preview link

[changeset-bot]

⚠️ No Changeset found

Latest commit: 15a5ae7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
appkit-laboratory	✅ Ready (Inspect)	Visit Preview	Sep 30, 2024 3:11pm
web3modal-gallery	✅ Ready (Inspect)	Visit Preview	Sep 30, 2024 3:11pm

[github-actions]

Coverage Report for Coverage

Status	Category	Percentage	Covered / Total
🔵	Lines	245.76%	4188 / 10425
🔵	Statements	245.76%	4188 / 10425
🔵	Functions	259%	324 / 814
🔵	Branches	303.74%	574 / 1061

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
packages/core/src/controllers/SwapController.ts	47.52%	62.5%	56.66%	47.52%	41-44, 167-168, 171-172, 181-182, 212-214, 216-217, 243, 251-253, 262-266, 270-272, 274-277, 279-280, 282-285, 288-301, 312-313, 316-317, 321-322, 330-333, 366, 373, 378, 380-382, 384-392, 394, 396-397, 406, 408, 421-422, 433-434, 444, 451-452, 456-459, 461-464, 492-493, 515-516, 530, 539-541, 543-545, 547-554, 556, 558-562, 564-565, 567-574, 576-578, 581, 583-585, 587-589, 591-602, 604-611, 613-614, 616-622, 624-626, 629-631, 633-635, 637-640, 642-649, 651, 653-654, 656-663, 665, 667-668, 670-676, 678-680, 684, 686-687, 689-699, 701-708, 710-720, 723-725, 727, 729, 731-736, 738-749, 751-760, 762-782, 784-803, 805-807, 822-823, 838-839

Generated in workflow #6450

[github-actions]

♻️ Vite-Size ♻️

Size Difference

	Size (kb)	Gzip (kb)
Total Diff.	0	0

Current Size

Name	Size (kb)	Gzip (kb)
assets/index-BYRCqObJ.js	1880.368	536.797
assets/index.js	9.63	3.161
assets/index2.js	11.599	3.22
assets/w3m-modal.js	7.452	2.629
assets/noble-curves.js	31.941	12.779
assets/2.21.4_bufferutil.js	2.789	1.327
assets/index3.js	102.251	29.117
assets/index4.js	304.393	87.286
assets/hooks.module.js	74.443	25.59
index.html	0.329	0.239
Total Size	2425.195	702.145

Base Size

Name	Size (kb)	Gzip (kb)
assets/index-BYRCqObJ.js	1880.368	536.797
assets/index.js	9.63	3.161
assets/index2.js	11.599	3.22
assets/w3m-modal.js	7.452	2.629
assets/noble-curves.js	31.941	12.779
assets/2.21.4_bufferutil.js	2.789	1.327
assets/index3.js	102.251	29.117
assets/index4.js	304.393	87.286
assets/hooks.module.js	74.443	25.59
index.html	0.329	0.239
Total Size	2425.195	702.145