Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove names flow on settings view for solana namespace #2989

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

zoruka
Copy link
Contributor

@zoruka zoruka commented Oct 2, 2024

Description

This PR removes names flow on settings view for solana namespace

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1033
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Oct 2, 2024

🦋 Changeset detected

Latest commit: 80a8bde

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@reown/appkit-scaffold-ui Patch
@apps/laboratory Patch
@reown/appkit-core Patch
@apps/demo Patch
@apps/gallery Patch
@examples/html-ethers Patch
@examples/html-ethers5 Patch
@examples/html-wagmi Patch
@examples/next-ethers Patch
@examples/next-wagmi Patch
@examples/react-ethers Patch
@examples/react-ethers5 Patch
@examples/react-solana Patch
@examples/react-wagmi Patch
@examples/vue-ethers5 Patch
@examples/vue-solana Patch
@examples/vue-wagmi Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-common Patch
@reown/appkit-ethers Patch
@reown/appkit-ethers5 Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-solana Patch
@reown/appkit-ui Patch
@reown/appkit-wagmi Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview Oct 2, 2024 9:20pm
web3modal-gallery ✅ Ready (Inspect) Visit Preview Oct 2, 2024 9:20pm

Copy link

linear bot commented Oct 2, 2024

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 245.10999999999999% 4259 / 18900
🔵 Statements 245.10999999999999% 4259 / 18900
🔵 Functions 261.23999999999995% 330 / 1004
🔵 Branches 312.56% 598 / 1274
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/core/src/controllers/NetworkController.ts 60.18% 68.29% 73.68% 60.18% 46-47, 53-56, 58-67, 75-76, 89-90, 93-94, 107-113, 126-127, 133-134, 148-151, 165-167, 169-171, 173, 175-182, 185-186, 188-190, 192-193, 195, 197-201, 203-204, 208-209, 221-222, 239-240, 243-244, 266-267, 277, 279-281, 283-284, 288
packages/core/src/utils/ConstantsUtil.ts 100% 100% 100% 100%
packages/scaffold-ui/src/views/w3m-account-settings-view/index.ts 0% 0% 0% 0% 1, 15-21, 23-24, 26, 28, 31, 33, 35, 37, 39, 41, 43, 45, 47, 49-74, 76-78, 81-84, 86, 88, 93, 96-98, 104-109, 115, 121-122, 125, 128-130, 134, 137, 142-144, 152, 155-161, 163, 169-170, 176, 178-184, 186, 188, 195, 197-200, 202-203, 205-214, 216-219, 221-223, 225-230, 232, 238-240, 243, 246, 248-250, 252-259, 261-263, 265-266, 268-272, 274-277, 279-283, 285-297, 299-303
Generated in workflow #6532 for commit 80a8bde by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Oct 2, 2024

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-CZxWHIs8.js 1890.31 540.402
assets/index.js 9.63 3.161
assets/index2.js 11.589 3.211
assets/w3m-modal.js 7.452 2.629
assets/noble-curves.js 31.941 12.779
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.286
assets/hooks.module.js 74.286 25.526
index.html 0.329 0.237
Total Size 2434.97 705.674

Base Size

Name Size (kb) Gzip (kb)
assets/index-CZxWHIs8.js 1890.31 540.402
assets/index.js 9.63 3.161
assets/index2.js 11.589 3.211
assets/w3m-modal.js 7.452 2.629
assets/noble-curves.js 31.941 12.779
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.286
assets/hooks.module.js 74.286 25.526
index.html 0.329 0.237
Total Size 2434.97 705.674

@zoruka zoruka merged commit d40f978 into main Oct 2, 2024
17 checks passed
@zoruka zoruka deleted the fix/remove-names-flow-for-solana branch October 2, 2024 21:51
@github-actions github-actions bot mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants