-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: drop assert syntax to support old and new nodejs versions #3036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 154363a The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coverage Report for Coverage
File Coverage
|
♻️ Vite-Size ♻️Size Difference
Current Size
Base Size
|
enesozturk
force-pushed
the
refactor/remove-assert-syntax-to-import-json
branch
from
October 8, 2024 14:55
f05c514
to
ff245fa
Compare
tomiir
approved these changes
Oct 8, 2024
This was referenced Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are using the
assert
syntatic sugar to import JSON files. This has some issues:assert
has been replaced withwith
and it's not being supported.with
is not supported.So using these keywords are problematic and not using them too. So here we need to find another solution to make it work in both browser or server side environments (Next.js or similar frameworks)
This PR introduces changes to how we are getting the latest version while we generating the
sdkVersion
value inpackages/appkit
exports.We can use
prebuild
and run a script on build time, and set the version from package.json to a file and use it anywhere. This will be processed only AppKit's build time. The consumer apps will be using the generated constant to createsdkVersion
value on runtime.Type of change
Associated Issues
For Linear issues: Closes APKT-1204
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist