Add missing setProvider call #3048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fb79dcd The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coverage Report for Coverage
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
♻️ Vite-Size ♻️Size Difference
Current Size
Base Size
|
|
@KannuSingh can you add changeset file please? |
enesozturk
reviewed
Oct 9, 2024
enesozturk
reviewed
Oct 9, 2024
| const mockConnector = { | ||
| id: 'mockConnector', | ||
| name: 'Mock Connector', | ||
| getProvider: vi.fn().mockResolvedValue({}) |
There was a problem hiding this comment.
What this does test? shouldn't the connector be returning undefined?
There was a problem hiding this comment.
this is an existing test for syncAccount, just added getProvider on mockConnector bc I added connector.getProvider call in the syncAccount
tomiir
reviewed
Oct 9, 2024
enesozturk
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For Embedded wallet, on successful connection, provider returns undefined for below code.
ProviderUtil.getProvider(CommonConstantsUtil.CHAIN.EVM)This PR is to fix this issue.
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist