Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve mobile connection ux #3058

Merged
merged 7 commits into from
Oct 10, 2024
Merged

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Oct 10, 2024

Description

Added a few improvements to how we're handling connection on mobile.

  • We don't show "Try again" button right away, instead we show it after 5 seconds.
  • If connection takes longer than 3 seconds we show Hold tight... it's taking longer than expected message

Also added mobile e2e tests. The devices that are being used are iPhone 12 and Galaxy S5

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-766

Showcase (Optional)

preview.MOV

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Oct 10, 2024

🦋 Changeset detected

Latest commit: 8aea542

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@reown/appkit-scaffold-ui Patch
@apps/laboratory Patch
@reown/appkit-core Patch
@apps/demo Patch
@apps/gallery Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-common Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview Oct 10, 2024 11:50am
web3modal-gallery ✅ Ready (Inspect) Visit Preview Oct 10, 2024 11:50am

Copy link
Contributor

github-actions bot commented Oct 10, 2024

Warnings
⚠️ Changes were made to one or more package.json(s), but not to pnpm-lock.yaml
⚠️ Testing spec changed

Generated by 🚫 dangerJS against 8aea542

Copy link
Contributor

github-actions bot commented Oct 10, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 321.87% 4415 / 19253
🔵 Statements 321.87% 4415 / 19253
🔵 Functions 343.16% 346 / 1030
🔵 Branches 379.87% 636 / 1327
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/core/src/utils/ConstantsUtil.ts 100% 100% 100% 100%
packages/scaffold-ui/src/partials/w3m-all-wallets-search/index.ts 0% 0% 0% 0% 1-7, 9-11, 14, 17, 19, 22-23, 25-28, 31-38, 40-42, 44-45, 57, 59, 61, 66-67, 69-71, 74, 77, 79-87
packages/scaffold-ui/src/partials/w3m-connecting-wc-mobile/index.ts 0% 0% 0% 0% 1, 6-8, 10-13, 15-37, 39-44, 47-52, 54-79, 81-90
packages/scaffold-ui/src/utils/w3m-connecting-widget/index.ts 0% 0% 0% 0% 1, 8, 10-13, 15-16, 19, 21, 23, 25, 27, 29, 31, 33, 35, 37-38, 40, 43, 45, 47, 49, 51, 53, 55, 57, 59, 61, 63-77, 79-82, 84-87, 89-92, 95-97, 99-101, 103, 105-107, 109-111, 113, 115-116, 119, 123, 125, 139-140, 142, 145-146, 150-151, 154-155, 158, 161-164, 170, 172, 174, 177-186, 188-198, 200-202, 204-205, 208-218
Generated in workflow #6747 for commit 8aea542 by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Oct 10, 2024

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-B67D8xC3.js 1891.957 539.969
assets/index.js 9.642 3.151
assets/index2.js 11.588 3.209
assets/w3m-modal.js 7.504 2.656
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.285
assets/hooks.module.js 74.286 25.524
index.html 0.329 0.238
Total Size 2436.68 705.253

Base Size

Name Size (kb) Gzip (kb)
assets/index-B67D8xC3.js 1891.957 539.969
assets/index.js 9.642 3.151
assets/index2.js 11.588 3.209
assets/w3m-modal.js 7.504 2.656
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.116
assets/index4.js 304.393 87.285
assets/hooks.module.js 74.286 25.524
index.html 0.329 0.238
Total Size 2436.68 705.253

Copy link
Contributor

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love all the thorough tests! thank you!

@magiziz magiziz merged commit 91c1be7 into main Oct 10, 2024
17 checks passed
@magiziz magiziz deleted the chore/deep-link-ux-improvement branch October 10, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants