Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve account name selection flow #3068

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Oct 10, 2024

Description

Currently if you want to choose an account name you are forced to click on the blue arrow on the input field instead of the account name card itself. For this PR we make sure that the account name card is also clickable.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1236
For GH issues: closes #...

Showcase (Optional)

approve-account-flow.mov

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Oct 10, 2024

🦋 Changeset detected

Latest commit: 153ef82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@reown/appkit-scaffold-ui Patch
@apps/laboratory Patch
@apps/demo Patch
@apps/gallery Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

linear bot commented Oct 10, 2024

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview Oct 11, 2024 1:28pm
web3modal-gallery ✅ Ready (Inspect) Visit Preview Oct 11, 2024 1:28pm

@magiziz magiziz requested review from tomiir and enesozturk October 10, 2024 18:08
Copy link
Contributor

github-actions bot commented Oct 10, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 321.87% 4415 / 19255
🔵 Statements 321.87% 4415 / 19255
🔵 Functions 343.16% 346 / 1030
🔵 Branches 379.87% 636 / 1327
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/scaffold-ui/src/partials/w3m-header/index.ts 0% 0% 0% 0% 1, 11-17, 20, 23-29, 31-88, 90-92, 95, 98, 100, 102, 104, 106, 108, 110, 112, 114, 116-130, 132-134, 137-140, 143, 148-151, 153-157, 159-167, 169-170, 172-174, 176, 178, 180, 184, 186-187, 189, 191, 197, 199, 202, 204-210, 212, 214-215, 218-220, 222, 224-225, 228-229, 231, 233-234, 237, 239, 241-246, 248-251, 253-254, 256-259, 261-262, 264-265, 267-273, 275-276, 278-304, 306-309
packages/scaffold-ui/src/views/w3m-register-account-name-view/index.ts 0% 0% 0% 0% 1-5, 12-14, 16-18, 21-22, 25, 27, 29, 31, 33, 35, 37, 39-55, 58-60, 62-66, 69-70, 75, 77, 79-81, 84, 87, 90, 93-94, 96-97, 102, 106-107, 109-122, 124-130, 132-134, 136-139, 141-144, 146-149, 151, 153, 156, 159, 162-163, 165, 167, 169-170, 172, 175, 178, 182, 184-190, 192, 194-235, 237-242
Generated in workflow #6780 for commit 153ef82 by the Vitest Coverage Report Action

@magiziz magiziz merged commit bf5bfb3 into main Oct 11, 2024
16 checks passed
@magiziz magiziz deleted the chore/improve-account-name-registration branch October 11, 2024 13:33
This was referenced Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants