Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add max timeouts for frame requests #3073

Merged
merged 10 commits into from
Oct 11, 2024

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Oct 11, 2024

Description

Edited maximum timeouts for frame requests. We currently have our timeout duration on 15 seconds, but we don't throw an error and the timeout duration is low as well. We instead decided to increase the timeout duration to 25 - 30 seconds and also abort the request if it takes that long.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1147

Showcase (Optional)

Here is an example if the request takes more than 30 seconds.

image

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

linear bot commented Oct 11, 2024

Copy link

changeset-bot bot commented Oct 11, 2024

🦋 Changeset detected

Latest commit: aaa6528

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@apps/laboratory Patch
@reown/appkit-wallet Patch
@reown/appkit-ui Patch
@apps/demo Patch
@apps/gallery Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview Oct 11, 2024 2:28pm
web3modal-gallery ✅ Ready (Inspect) Visit Preview Oct 11, 2024 2:28pm

@magiziz magiziz requested review from enesozturk and zoruka October 11, 2024 13:17
Copy link
Contributor

github-actions bot commented Oct 11, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 320.28000000000003% 4415 / 19272
🔵 Statements 320.28000000000003% 4415 / 19272
🔵 Functions 343.16% 346 / 1030
🔵 Branches 379.87% 636 / 1327
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/ui/src/composites/wui-snackbar/index.ts 0% 0% 0% 0%
Generated in workflow #6792 for commit aaa6528 by the Vitest Coverage Report Action

@enesozturk enesozturk merged commit 3627dd1 into main Oct 11, 2024
16 checks passed
@enesozturk enesozturk deleted the chore/frame-request-timeout-abort branch October 11, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants