Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/update cdn example apps #3074

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Conversation

enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Oct 11, 2024

Description

Refactor Wagmi CDN example to deploy to Vercel. Read recent published version ID programatically since we don't use the CDN as npm registery package.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: 0625328

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview Oct 14, 2024 8:57am
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 8:57am
web3modal-gallery ✅ Ready (Inspect) Visit Preview Oct 14, 2024 8:57am

Copy link
Contributor

github-actions bot commented Oct 11, 2024

Warnings
⚠️ Changes were made to one or more package.json(s), but not to pnpm-lock.yaml

Generated by 🚫 dangerJS against 0625328

Copy link
Contributor

github-actions bot commented Oct 11, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 320.28000000000003% 4415 / 19272
🔵 Statements 320.28000000000003% 4415 / 19272
🔵 Functions 343.16% 346 / 1030
🔵 Branches 379.87% 636 / 1327
File CoverageNo changed files found.
Generated in workflow #6794 for commit 0625328 by the Vitest Coverage Report Action

@enesozturk enesozturk merged commit 0f26117 into main Oct 14, 2024
18 checks passed
@enesozturk enesozturk deleted the chore/update-cdn-example-apps branch October 14, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants