Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reown.id suggestions #3080

Merged
merged 6 commits into from
Oct 16, 2024
Merged

fix: reown.id suggestions #3080

merged 6 commits into from
Oct 16, 2024

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Oct 14, 2024

Description

Fixes issue where suggestions would be fetched without specifying reown.id and resulted in suggestions for wcn.id zone instead.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

Closes APKT-1291

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

linear bot commented Oct 14, 2024

Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: c2482cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@apps/laboratory Patch
@reown/appkit-core Patch
@apps/demo Patch
@apps/gallery Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-common Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 11:23am
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 11:23am
web3modal-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 11:23am

Copy link
Contributor

github-actions bot commented Oct 14, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 308.05% 4456 / 19392
🔵 Statements 308.05% 4456 / 19392
🔵 Functions 330.94% 348 / 1036
🔵 Branches 376.68999999999994% 638 / 1334
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/appkit/exports/constants.ts 0% 0% 0% 0% 1
packages/core/src/controllers/BlockchainApiController.ts 29.07% 100% 0% 29.07% 131-140, 143-162, 165-186, 189-196, 199-210, 213, 215-228, 231, 233-245, 248-270, 273-278, 280-294, 297, 299-312, 315-322, 325-333, 336-343, 346-358, 361-380, 382-383, 386-387, 390-395, 397-401, 404-416, 418-419, 421-430, 433-435
packages/core/src/controllers/EnsController.ts 81.3% 57.89% 60% 81.3% 38-39, 42-43, 77-78, 95-97, 103-104, 109-110, 127-128, 135-136, 149-151, 160, 162-163
Generated in workflow #6861 for commit c2482cf by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants