chore: siwe to siwx migration #3194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b11becf The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…siwe-to-siwx-migration
…siwe-to-siwx-migration
zoruka
commented
Nov 15, 2024
apps/laboratory/tests/multichain/multichain-ethers-solana-email-siwe.spec.ts
Show resolved
Hide resolved
| @@ -53,5 +56,5 @@ test('it should switch networks and sign siwe', async () => { | |||
| test('it should switch to Solana and validate chain title', async () => { | |||
| const chainName = 'Solana' | |||
| await modalPage.switchNetwork(chainName) | |||
| await modalValidator.expectSwitchChainView(chainName.toLocaleLowerCase()) | |||
| await modalValidator.expectSwitchedNetworkOnNetworksView(chainName) | |||
There was a problem hiding this comment.
Again, if the expected behavior is to keep switch chain view open after the chain is switched, this test was wrong.
There was a problem hiding this comment.
how was it passing before?
tomiir
approved these changes
Nov 18, 2024
…siwe-to-siwx-migration
…siwe-to-siwx-migration
|
wen release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SIWXUtilobject centralizing the logic spread around the code;LocalStorageto validate getting sessions.Type of change
Associated Issues
For Linear issues: Closes APKT-1408
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist