Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: walletconnect certified #3206

Merged
merged 31 commits into from
Nov 10, 2024
Merged

feat: walletconnect certified #3206

merged 31 commits into from
Nov 10, 2024

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Nov 6, 2024

Description

  • Added certified filtering feature to the all wallets view.
  • Refactored the <wui-snackbar> component to display svg icons.
  • Updated the wallet list UI in the all wallets view.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1362

Showcase (Optional)

Screen.Recording.2024-11-06.at.13.40.58.mov

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

linear bot commented Nov 6, 2024

Copy link

changeset-bot bot commented Nov 6, 2024

🦋 Changeset detected

Latest commit: 7b33ff6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@reown/appkit-scaffold-ui Patch
@apps/laboratory Patch
@reown/appkit-core Patch
@apps/gallery Patch
@reown/appkit-ui Patch
@apps/demo Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-polkadot Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-common Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2024 3:24pm
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2024 3:24pm
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2024 3:24pm
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2024 3:24pm
web3modal-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2024 3:24pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
appkit-gallery ⬜️ Ignored (Inspect) Visit Preview Nov 10, 2024 3:24pm

@magiziz magiziz changed the title feat: wc certified [DO NOT MERGE] feat: wc certified Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 340.18999999999994% 4512 / 19108
🔵 Statements 340.18999999999994% 4512 / 19108
🔵 Functions 375.96000000000004% 372 / 1097
🔵 Branches 465.5% 683 / 1397
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/core/src/controllers/ApiController.ts 91.77% 68% 80% 91.77% 57-58, 72-73, 130-131, 143, 181, 268-272, 288-293
packages/core/src/controllers/SnackController.ts 78% 83.33% 71.42% 78% 28-29, 32-33, 62-68
packages/core/src/utils/TypeUtil.ts 100% 100% 100% 100%
packages/scaffold-ui/src/partials/w3m-all-wallets-list/styles.ts 0% 0% 0% 0% 1-3
packages/scaffold-ui/src/partials/w3m-all-wallets-list-item/index.ts 0% 0% 0% 0% 1-105
packages/scaffold-ui/src/partials/w3m-all-wallets-list-item/styles.ts 0% 0% 0% 0% 1-3
packages/scaffold-ui/src/partials/w3m-all-wallets-search/index.ts 0% 0% 0% 0% 1-92
packages/scaffold-ui/src/partials/w3m-all-wallets-search/styles.ts 0% 0% 0% 0% 1-3
packages/scaffold-ui/src/partials/w3m-snackbar/index.ts 0% 0% 0% 0% 1-101
packages/scaffold-ui/src/views/w3m-all-wallets-view/index.ts 0% 0% 0% 0% 1-88
packages/ui/index.ts 0% 0% 0% 0%
packages/ui/src/assets/svg/walletconnect.ts 0% 0% 0% 0%
packages/ui/src/components/wui-icon/index.ts 0% 0% 0% 0%
packages/ui/src/composites/wui-card-select-loader/styles.ts 0% 0% 0% 0%
packages/ui/src/composites/wui-certified-switch/index.ts 0% 0% 0% 0%
packages/ui/src/composites/wui-certified-switch/styles.ts 0% 0% 0% 0%
packages/ui/src/composites/wui-snackbar/index.ts 0% 0% 0% 0%
packages/ui/src/composites/wui-switch/index.ts 0% 0% 0% 0%
packages/ui/src/composites/wui-switch/styles.ts 0% 0% 0% 0%
packages/ui/src/utils/JSXTypeUtil.ts 100% 100% 100% 100%
packages/ui/src/utils/TypeUtil.ts 0% 100% 100% 0%
Generated in workflow #7308 for commit 7b33ff6 by the Vitest Coverage Report Action

@magiziz magiziz changed the title [DO NOT MERGE] feat: wc certified [DO NOT MERGE] feat: walletconnect certified Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants