-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: state and local storage sync and persistent when use multiple adapters #3419
Merged
enesozturk
merged 26 commits into
main
from
enes/apkt-1689-connecting-to-multiple-adapter-instance-with-mm-and
Dec 10, 2024
Merged
fix: state and local storage sync and persistent when use multiple adapters #3419
enesozturk
merged 26 commits into
main
from
enes/apkt-1689-connecting-to-multiple-adapter-instance-with-mm-and
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3482663 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…r-instance-with-mm-and
enesozturk
changed the title
enes/apkt 1689 connecting to multiple adapter instance with mm and
fix: state and local storage sync and persistent when use multiple adapters
Dec 10, 2024
enesozturk
force-pushed
the
enes/apkt-1689-connecting-to-multiple-adapter-instance-with-mm-and
branch
from
December 10, 2024 14:59
b99c0e3
to
b6a8dc5
Compare
enesozturk
force-pushed
the
enes/apkt-1689-connecting-to-multiple-adapter-instance-with-mm-and
branch
from
December 10, 2024 16:08
5449af5
to
5173f98
Compare
enesozturk
commented
Dec 10, 2024
enesozturk
commented
Dec 10, 2024
enesozturk
commented
Dec 10, 2024
enesozturk
deleted the
enes/apkt-1689-connecting-to-multiple-adapter-instance-with-mm-and
branch
December 10, 2024 17:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors state and local storage syncronisation to persist state, specificially for multiple adapter instances.
When we have multiple adapters enabled, we are not handling the initialization of the Appkit depending on the local storage and also not updating the local storage when switching between namespaces.
This PR introduces changes to refactor local storage values, removes
CONNECTED_NAMESPACE
value since we don't even need it because we haveACTIVE_CAIP_NETWORK_ID
value. Also updates controllers and Wagmi adapters depending on these.Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist