Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enableWalletGuide option #3420

Merged
merged 5 commits into from
Dec 10, 2024
Merged

feat: enableWalletGuide option #3420

merged 5 commits into from
Dec 10, 2024

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Dec 10, 2024

Description

Added an enableWalletGuide to allow disabling the wallet guide footer when social or email logins are enabled.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1235
For GH issues: closes #...

Showcase (Optional)

Before:

Screenshot 2024-12-10 at 11 10 06

After:

Screenshot 2024-12-10 at 11 11 30

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

linear bot commented Dec 10, 2024

Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: d3de572

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@reown/appkit-scaffold-ui Patch
@reown/appkit Patch
@reown/appkit-core Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@apps/builder Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@magiziz magiziz requested review from tomiir and enesozturk December 10, 2024 11:58
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 4:17pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 4:17pm
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 4:17pm
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 4:17pm
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 4:17pm

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 51.94% 13743 / 26456
🔵 Statements 51.94% 13743 / 26456
🔵 Functions 39.21% 985 / 2512
🔵 Branches 75.24% 1666 / 2214
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/src/client.ts 19.51% 100% 0% 19.51% 184-192, 195-196, 199-235, 239-241, 244-246, 249-250, 254-255, 258-259, 262-271, 274-277, 280-283, 286-287, 290-291, 294-295, 298-300, 303-304, 307-308, 311-313, 316-317, 320-321, 324-335, 338-347, 350-351, 354-355, 358-359, 362-363, 366-367, 370-371, 374-375, 378-379, 382-383, 386-387, 390-391, 394-395, 398-399, 402-403, 406-409, 614-615, 618-621, 624-625, 628-629, 632-633, 636-637, 640-641, 645-728, 731-742, 745-765, 768-774, 777-786, 789-1105, 1108-1109, 1112-1244, 1247-1273, 1276-1344, 1347-1356, 1359-1369, 1372-1450, 1453-1473, 1476-1488, 1491-1515, 1521-1535, 1538-1577, 1580-1623, 1626-1637, 1640-1652, 1655-1700, 1703-1704, 1707-1716, 1719-1730, 1733-1742, 1745-1758, 1761-1811, 1814-1825, 1828-1838, 1841-1857
packages/core/src/controllers/OptionsController.ts 69.74% 83.33% 29.82% 69.74% 163, 168-169, 172-175, 186, 202, 206, 210, 214, 218, 222, 234, 238, 242, 246, 250, 254, 258, 266-269, 273-276, 280-283, 287-290
packages/scaffold-ui/src/views/w3m-connect-view/index.ts 84.55% 86.59% 76.47% 84.55% 44-45, 53-56, 117, 125-126, 139, 153, 164, 219, 234, 248, 262-263, 279, 303-304, 316, 327, 338-349, 354-355, 358-359
Generated in workflow #8006 for commit d3de572 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants