refactor: filter out the duplicate wallets when there is both injected and recent #3446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: aee92df The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
enesozturk
requested review from
magiziz,
tomiir,
svenvoskamp and
zoruka
and removed request for
magiziz and
tomiir
…-when-using-wallet-button
magiziz
approved these changes
Dec 12, 2024
svenvoskamp
approved these changes
Dec 12, 2024
enesozturk
deleted the
enes/apkt-1734-trust-wallet-duplicate-wallet-when-using-wallet-button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a specific case for the wallets which have both extension and mobile options. When users select the wallet from "All Wallets" view and scan the QR code, we are saving that wallet into our local storage and next time when they open the connect view, they see that wallet with "Recent" tag. But if same wallet also available as extension, there is a duplication occurs.
This PR introduces changes to remove that duplication by filtering out the available connectors with recent list.
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist