Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:fix allowUnsupportedChain param to work correctly #3447

Merged
merged 21 commits into from
Dec 12, 2024

Conversation

svenvoskamp
Copy link
Contributor

@svenvoskamp svenvoskamp commented Dec 12, 2024

Description

The param allowUnsupportedChain didn't work correctly anymore. Users would still see the unsupportedChaid UI.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1744 https://linear.app/reown/issue/APKT-1744/feature-request-to-restore-deprecated-parameter-in-appkit
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

linear bot commented Dec 12, 2024

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 11:15am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 11:15am
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 11:15am
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 11:15am
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 11:15am

Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: b9c44e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@reown/appkit-scaffold-ui Patch
@reown/appkit Patch
@reown/appkit-core Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 53.76% 14713 / 27363
🔵 Statements 53.76% 14713 / 27363
🔵 Functions 40.61% 1056 / 2600
🔵 Branches 75.25% 1864 / 2477
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/src/client.ts 19.06% 100% 0% 19.06% 186-193, 196-197, 200-235, 239-241, 244-246, 249-250, 254-255, 258-259, 262-271, 274-277, 280-283, 286-287, 290-291, 294-295, 298-300, 303-304, 307-308, 311-313, 316-317, 320-321, 324-335, 338-347, 350-351, 354-355, 358-359, 362-363, 366-367, 370-371, 374-375, 378-379, 382-383, 386-387, 390-391, 394-395, 398-399, 402-403, 406-409, 614-615, 618-621, 624-625, 628-629, 632-633, 636-637, 640-641, 645-732, 735-746, 749-769, 772-778, 781-790, 793-1130, 1133-1134, 1137-1269, 1272-1298, 1301-1369, 1372-1381, 1384-1394, 1397-1475, 1478-1498, 1501-1512, 1515-1540, 1546-1567, 1570-1609, 1612-1655, 1658-1669, 1672-1684, 1687-1727, 1730-1731, 1734-1743, 1746-1763, 1766-1786, 1789-1798, 1801-1817, 1820-1870, 1873-1884, 1887-1897, 1900-1916
packages/core/src/controllers/ChainController.ts 81.88% 74.39% 73.84% 81.88% 72-74, 80, 88, 92-100, 157-158, 200-207, 212-213, 220, 238-239, 243-250, 283-285, 294-295, 298-299, 308-309, 314-315, 331-332, 337-338, 350-351, 384-391, 399, 431-437, 450-451, 470-472, 496-497
packages/core/src/controllers/OptionsController.ts 70.49% 84.61% 30.5% 70.49% 168, 173-174, 177-180, 191, 207, 211, 215, 219, 223, 227, 239, 243, 247, 251, 255, 259, 263, 271-274, 278-281, 285-288, 292-295
packages/scaffold-ui/src/modal/w3m-account-button/index.ts 85% 76.92% 60% 85% 56, 59, 66-70, 77-78, 83-84, 107
packages/scaffold-ui/src/modal/w3m-network-button/index.ts 70.12% 75% 50% 70.12% 48, 51, 54-58, 66-67, 73, 85, 98-106, 110-114
Generated in workflow #8072 for commit b9c44e8 by the Vitest Coverage Report Action

@lukaisailovic
Copy link
Collaborator

We're missing tests for the scaffold-ui w3m-account-button. getLabel method is influenced by allowUnsupportedChain and we're not testing that code path. Same with the render/ui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants