fix: correct return of chain when connecting to bitcoin #3450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c37b34d The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
tomiir
reviewed
Dec 12, 2024
Comment on lines
+46
to
+51
| case 'bitcoin:mainnet': | ||
| return chain.caipNetworkId === bitcoin.caipNetworkId | ||
| case 'bitcoin:testnet': | ||
| return chain.caipNetworkId === bitcoinTestnet.caipNetworkId | ||
| default: | ||
| return chain.caipNetworkId === chainId |
There was a problem hiding this comment.
wallet standard has a different set of ids?
There was a problem hiding this comment.
yeah, they use these aliases and not exactly caip-2
tomiir
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the chainId response when connecting to bitcoin with multichain adapters.
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist