fix: top-level ELB error metric and logs, downscale to min capacities #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris13524
changed the title
chris13524
changed the title
chris13524
commented
Mar 22, 2024
Comment on lines
+60
to
+61
| // panels.app.http_request_rate(ds, vars) { gridPos: pos._4 }, | ||
| // panels.app.http_request_latency(ds, vars) { gridPos: pos._4 }, |
There was a problem hiding this comment.
These panels were specific to Notify Server, but leaving them here as a reminder to put request rate and request latency up here at the top as those are important high-level metrics.
nopestack
reviewed
Mar 24, 2024
| @@ -47,7 +47,7 @@ curl -X POST "http://localhost:3000/v1?chainId=eip155:1&projectId=someid" --data | |||
| ## Testing | |||
|
|
|||
| ```bash | |||
| just amigood | |||
| just devloop | |||
There was a problem hiding this comment.
amigood makes more sense than devloop imo but it's fine
There was a problem hiding this comment.
The idea was "am I good" to commit but it was awkward to type and the concept of a "developer loop" is more familiar to people.
nopestack
approved these changes
Mar 24, 2024
nopestack
approved these changes
Mar 25, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prodstagingjust amigoodtojust devlooplike in other repos e.g. Notify ServerHow Has This Been Tested?
Not tested
Due Diligence