Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get config from self after build_config() #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mibes
Copy link

@mibes mibes commented Nov 5, 2022

Description

build_config() mutates self. This pull request ensures that the config is cloned from self after build_config() is called.

Resolves #13

How Has This Been Tested?

Used the forked code in production, and confirmed that this is now working as expected.

Due Dilligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@vhawley
Copy link

vhawley commented Jan 5, 2023

I am unaffiliated with this project, but I have tested this change and confirm it works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unwrap of a None value when config is not set
2 participants