fix: dynamic chain support #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris13524
force-pushed
the
fix/dynamic-chain-support
branch
from
1314da6 to
e45dc07
Compare
nopestack
reviewed
Mar 11, 2024
| @@ -104,3 +105,4 @@ build-info-build = "0.0" | |||
| # [patch.'https://github.com/WalletConnect/WalletConnectRust.git'] | |||
| # relay_rpc = { path = "../WalletConnectRust/relay_rpc" } | |||
| # relay_client = { path = "../WalletConnectRust/relay_client" } | |||
| # blockchain_api = { path = "../WalletConnectRust/blockchain_api" } | |||
There was a problem hiding this comment.
I'm curious, do we need to maintain these lines commented out?
There was a problem hiding this comment.
So it's easy to un-comment and be able to test local changes easily
nopestack
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
didn't see issues, @geekbrother can you also take a look please?
…into fix/dynamic-chain-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates to latest version of WalletConnectRust to support dynamically supporting chains.
Remaining work:
How Has This Been Tested?
Manually by running Blockchain API locally:
BLOCKCHAIN_API_ENDPOINTenv var when runningjust devloopDue Diligence