Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clippy): examples #63

Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix(clippy): examples #63

merged 1 commit into from
Feb 15, 2024

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Feb 14, 2024

Description

--examples weren't being checked, and I'm not sure why we were using --tests instead of simply --all-targets which covers everything.

How Has This Been Tested?

N/A

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this Feb 14, 2024
@@ -64,7 +64,7 @@ async fn main() -> anyhow::Result<()> {

let messages = client2.fetch(topic).await?.messages;
let message = messages
.get(0)
.first()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -53,7 +53,7 @@ clippy:

if command -v cargo-clippy >/dev/null; then
echo '==> Running clippy'
cargo clippy --workspace --all-features --tests -- -D clippy::all -W clippy::style
cargo clippy --workspace --all-features --all-targets -- -D clippy::all -W clippy::style

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chris13524 chris13524 merged commit e28cdf1 into main Feb 15, 2024
9 checks passed
@chris13524 chris13524 deleted the fix/clippy-examples branch February 15, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants