feat: seaprate blocking methods #72
Conversation
| @@ -142,21 +142,13 @@ impl Client { | |||
| /// when fully processed by the relay. | |||
| /// Note: This function is experimental and will likely be removed in the | |||
There was a problem hiding this comment.
Is it still experimental?
There was a problem hiding this comment.
We haven't thought about it, but we've changed the API a couple of times already. So yeah, I'd consider it experimental still.
| ) -> ResponseFuture<BatchSubscribe> { | ||
| let (request, response) = create_request(BatchSubscribe { | ||
| ) -> impl Future< | ||
| Output = Result< |
There was a problem hiding this comment.
A bit ugly, I would use a type alias for this. clippy should have noticed this 🤔
There was a problem hiding this comment.
Why isn't the function just async?
There was a problem hiding this comment.
Making the function async would capture self reference for the lifetime of that future, which I wanted to avoid initially. Now why would I want to avoid capturing self is another question. Maybe in the initial implementation there were some methods that required &mut self, so I didn't want to mix immutable and mutable borrowing, not sure. But yeah, now that the client API is stable-ish, we could just convert these methods to be async and return anonymous futures.
| }) | ||
| .await | ||
| ) -> Result< | ||
| Vec<Result<SubscriptionId, Error<rpc::SubscriptionError>>>, |
There was a problem hiding this comment.
Why return SubscriptionId still? Maybe change to ()?
There was a problem hiding this comment.
I guess doesn't hurt to have in the future if needed
Description
This creates a separate
irn_subscribeBlockingandirn_batchSubscribeBlockingmethods which were previously behind theblockflag in the main method payloads.Also removes the requirement to pass subscription IDs to unsubscribe.
How Has This Been Tested?
Relay integration.
Due Diligence