Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump http deps #77

Merged
merged 2 commits into from
Apr 15, 2024
Merged

fix: bump http deps #77

merged 2 commits into from
Apr 15, 2024

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Apr 4, 2024

Description

Bumps to the latest reqwest version and related dependencies. Necessary for the rennovatebot PR on Notify Server: WalletConnect/notify-server#467

How Has This Been Tested?

Existing tests and in WalletConnect/notify-server#467

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this Apr 4, 2024
@chris13524 chris13524 marked this pull request as ready for review April 8, 2024 13:24
@@ -5,7 +5,7 @@ edition = "2021"

[dependencies]
relay_rpc = { path = "../relay_rpc" }
reqwest = "0.11"
reqwest = { version = "0.12.2", features = ["json"] }
Copy link
Contributor

@geekbrother geekbrother Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the version without patch number? That will allow us to update to the latest patch version without hardcoding it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See convo here it does allow updating the latest version.

@chris13524 chris13524 merged commit b4c8f4c into main Apr 15, 2024
8 checks passed
@chris13524 chris13524 deleted the fix/bump-http-deps branch April 15, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants