Add Wasm build target #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougEfresh
commented
Dec 3, 2024
| @@ -104,6 +104,7 @@ impl ConnectionOptions { | |||
| Ok(url) | |||
| } | |||
|
|
|||
| #[cfg(not(target_arch = "wasm32"))] | |||
| fn as_ws_request(&self) -> Result<HttpRequest<()>, RequestBuildError> { | |||
| use { | |||
| crate::websocket::WebsocketClientError, | |||
There was a problem hiding this comment.
tokio_tungstenite::tungstenite::client::IntoClientRequest, is not available in wasm target
dougEfresh
commented
Dec 3, 2024
| inbound::*, | ||
| outbound::*, | ||
| stream::*, | ||
| tokio_tungstenite::tungstenite::protocol::CloseFrame, |
There was a problem hiding this comment.
CloseFrame from tokio_tungstenite has different structure when wasm
dougEfresh
commented
Dec 3, 2024
| wasm_bindgen_futures::spawn_local(fut); | ||
|
|
||
| #[cfg(not(target_arch = "wasm32"))] | ||
| tokio::spawn(fut); |
There was a problem hiding this comment.
No support for tokio::spawn in wasm
dougEfresh
commented
Dec 3, 2024
| #[cfg(target_arch = "wasm32")] | ||
| pub async fn create_stream(request: HttpRequest<()>) -> Result<ClientStream, WebsocketClientError> { | ||
| let url = format!("{}", request.uri()); | ||
| let socket = connect_async(url) |
There was a problem hiding this comment.
connect function in wasm only support URL
dougEfresh
commented
Dec 3, 2024
| fn is_terminated(&self) -> bool { | ||
| self.socket.is_terminated() | ||
| } | ||
|
|
There was a problem hiding this comment.
No access to TcpSocket, so cannot determine if connected
dougEfresh
commented
Dec 3, 2024
| @@ -67,7 +67,7 @@ impl Default for JwtHeader<'_> { | |||
| } | |||
| } | |||
|
|
|||
| impl<'a> JwtHeader<'a> { | |||
| impl JwtHeader<'_> { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for wasm32-unknown-uknown target.
I made use of
#[cfg(target_arch = "wasm32")]. Some features not support in wasm32:For example, since low-level sockets are not available, the
is_terminatedfunction always returns true. Functionality, this doesn't break much. An error will be thrown when the client publishes a messageResolves #84
How Has This Been Tested?
There is a wasm_websocket_demo which runs successfully
Due Diligence