Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Smart Account relay connection + paymaster base #351

Merged
merged 17 commits into from
Feb 1, 2024

Conversation

tomiir
Copy link
Contributor

@tomiir tomiir commented Dec 15, 2023

Summary

  • Adds necessary logic to enable the wallet's Goerli SmartAccount usage via the WC relay 🚀
  • Adds Verifying Paymaster implementation, with a settings field where it can be toggled on/off if user decides to pay with native token. 🔍
  • Adds base code for ERC20 Paymaster integration.

Notes

  • Can use https://react-app.walletconnect.com/ to test it out!
  • eth_signTransaction does not currently work as Pimlico's smart client does not expose the funcitonality and viem's base client forbids smart accounts from signing transactions.

Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
decentralized-relay-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 9:57pm
decentralized-relay-wallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 9:57pm
malicious-dapp-verify-simulation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 9:57pm
react-auth-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 9:57pm
react-auth-wallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 9:57pm
react-dapp-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 9:57pm
react-wallet-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 9:57pm
vue-dapp-auth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 9:57pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
react-dapp-v2-cosmos-provider ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 9:57pm
react-dapp-v2-with-ethers ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 9:57pm
react-dapp-v2-with-web3js ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 9:57pm

… as EIP155Lib. Hooked up all operations on EIP155RequestHandler to smart accounts.
@arein
Copy link
Contributor

arein commented Feb 1, 2024

Screenshot 2024-01-31 at 11 51 16 PM

Awesome work! I think I found a small bug but don't think that needs to block this PR.

Repro steps:

  1. deploy smart account on sepolia
  2. connect https://lab.web3modal.com/library/ethers/
  3. see console error above

@arein arein requested a review from Bacis February 1, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants