Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: embedded cluster manager websocket #5015

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sgalsaleh
Copy link
Member

@sgalsaleh sgalsaleh commented Nov 19, 2024

What this PR does / why we need it:

Implements a WebSocket server for the EC manager to connect to.

Which issue(s) this PR fixes:

Does this PR require a test?

Does this PR require a release note?

NONE

Does this PR require documentation?

NONE

@sgalsaleh sgalsaleh added the type::feature New feature or request label Nov 19, 2024
@sgalsaleh sgalsaleh marked this pull request as ready for review November 21, 2024 16:23
}
}

func isWSConnClosed(nodeName string, err error) bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need a mutex?


if err := conn.WriteControl(websocket.PingMessage, []byte(pingMsg), time.Now().Add(1*time.Second)); err != nil {
if isWSConnClosed(nodeName, err) {
return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you log here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants