many minor adjustments for ClojureScript #357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch doesn't solve everything. It does get significantly further in compilation (builds with warnings), but more work would be required to make it actually work correctly. Suggestions/collaboration sought on achieving fully compatible.
|
Thanks for your contributions @timothypratley. Currently we're adjusting konserve for sync and async versions as preparations for the cljs port. Maybe @whilo and @groundedsage could have a look. |
|
You're welcome! Thanks for the heads up about Konserve. |
|
@timothypratley Thanks for your work! The rebase of the cljs support is planned after we have landed the current changes for scaling out in our 1.0 release. I assume you are aware of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch doesn't solve everything.
It does get significantly further in the compilation (builds with warnings),
but more work would be required to make it actually work correctly.
Suggestions/collaboration sought on achieving full compatibility.