Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce poetry bundle size #15

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Reduce poetry bundle size #15

merged 2 commits into from
Jul 31, 2023

Conversation

airportyh
Copy link
Collaborator

@airportyh airportyh commented Jul 31, 2023 •
edited
Loading

Why?

the poetry bundle size is getting big. Dug into the contents and we are including:

  • .git
  • the cache dir for the type checker used during dev
  • the tests directory
  • the build directory
  • more

Change

Use a white list instead of a black list in the tar command

@airportyh airportyh changed the title skip .pythonlibs contents when building bundle Reduce poetry bundle size Jul 31, 2023
@airportyh airportyh marked this pull request as ready for review July 31, 2023 16:56
@airportyh airportyh requested review from a team and ryantm and removed request for a team July 31, 2023 16:56
ryantm
ryantm reviewed Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. What are the size savings?

@airportyh
Copy link
Collaborator Author

16M down from 324M.

@airportyh airportyh merged commit a828dab into replit-1.5 Jul 31, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@airportyh @ryantm