Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/Poetry Runtime: Elide USERBASE with poetry internal deps #31

Merged

Conversation

blast-hardcheese
Copy link

Resolves https://ask.replit.com/t/nix-error-when-installing-or-uninstalling-packages/94756

The problem we were facing was that html5lib===1.0b8 was a dependency of redberry, which relied on python <=3.7.

~/ReplWorkspace$ poetry add redberry

cannot import name 'Mapping' from 'collections' (/nix/store/xf54733x4chbawkh1qvy9i1i4mlscy1c-python3-3.10.11/lib/python3.10/collections/__init__.py)

We need to preserve the full PYTHONPATH because poetry executes pip to uninstall packages, and if PYTHONPATH does not contain the PYTHONUSERBASE then it will silently not uninstall packages.

@blast-hardcheese blast-hardcheese requested a review from a team as a code owner January 5, 2024 22:05
@blast-hardcheese blast-hardcheese requested review from airportyh and removed request for a team January 5, 2024 22:05
…with poetry internal deps

The problem we were facing was that html5lib===1.0b8 was a dependency
of redberry, which relied on python <=3.7.

    ~/ReplWorkspace$ poetry add redberry

    cannot import name 'Mapping' from 'collections' (/nix/store/xf54733x4chbawkh1qvy9i1i4mlscy1c-python3-3.10.11/lib/python3.10/collections/__init__.py)

We need to preserve the full PYTHONPATH because poetry executes pip to
uninstall packages, and if PYTHONPATH does not contain the PYTHONUSERBASE
then it will silently not uninstall packages.
@blast-hardcheese blast-hardcheese force-pushed the dstewart/bug/poetry-runtime-elide-userbase branch from e69b559 to d4559ae Compare January 5, 2024 22:21
@blast-hardcheese blast-hardcheese merged commit 0a3947d into replit-1.5 Jan 5, 2024
12 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/bug/poetry-runtime-elide-userbase branch January 5, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants