Added module_name conversion to fix proj name comparison; backport pr… #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airportyh
requested review from
ryantm and
blast-hardcheese
and removed request for
a team
blast-hardcheese
approved these changes
Aug 13, 2024
ryantm
approved these changes
Aug 13, 2024
This change only ensures that projects whose name needs to be normalized (e.g. projects with a dash) behave the same way as projects whose name is a valid Python module name.
airportyh
force-pushed
the
th-fix-packages-include-erronously-added
branch
from
6b3fab3
to
db731f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… 8218
Why?
If you do
poetry init --no-interaction --name foo_barto init a poetry project. It erronously creates a
packages = [{include = "foo_bar"}]entry inpyproject.toml, causing poetry later to fail becausefoo_baris not a subdirectory.More context: https://replit.slack.com/archives/C03KS2B221W/p1723577758114809?thread_ts=1723568638.858709&cid=C03KS2B221W
Change
This was fixed in a newer version of poetry upstream. Cherry-picked the merge commit.
Test
poetry init --no-interaction --name foo_barnow no longer creates a
packagesentry.