-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base branch for protocol v2 #127
Commits on Jun 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 34dc578 - Browse repository at this point
Copy the full SHA 34dc578View commit details -
[protocol v2] RFC PROTOCOL V2 (#111)
* Update PROTOCOL.md * Update PROTOCOL.md Co-authored-by: Jacky Zhao <j.zhao2k19@gmail.com> * Update PROTOCOL.md * half-close semantics * Update PROTOCOL.md * Update PROTOCOL.md * Update PROTOCOL.md * Update PROTOCOL.md * Update PROTOCOL.md * Update PROTOCOL.md * Update PROTOCOL.md * Update PROTOCOL.md * Update PROTOCOL.md * Update PROTOCOL.md * Update PROTOCOL.md * Update PROTOCOL.md * Update PROTOCOL.md * Update PROTOCOL.md * Update PROTOCOL.md * fmt * Update PROTOCOL.md * Update PROTOCOL.md * Update PROTOCOL.md * Update PROTOCOL.md * Update PROTOCOL.md * Include reader-writer semantics --------- Co-authored-by: Jacky Zhao <j.zhao2k19@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c1bc78d - Browse repository at this point
Copy the full SHA c1bc78dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bbac0b2 - Browse repository at this point
Copy the full SHA bbac0b2View commit details -
ReadStream implementation (#130)
* ReadStream implementation * remove tee for now * Make the stream itself an iterable * Implement return for iterator * comment
Configuration menu - View commit details
-
Copy full SHA for 3675b23 - Browse repository at this point
Copy the full SHA 3675b23View commit details -
Configuration menu - View commit details
-
Copy full SHA for a802329 - Browse repository at this point
Copy the full SHA a802329View commit details -
Client uses ReadStream and WriteStream (#136)
* Client uses ReadStream * Client uses WriteStream * delete port config lol * Disable everything for handler.test.ts * no void 0
Configuration menu - View commit details
-
Copy full SHA for b5bf962 - Browse repository at this point
Copy the full SHA b5bf962View commit details -
Configuration menu - View commit details
-
Copy full SHA for 590837c - Browse repository at this point
Copy the full SHA 590837cView commit details -
Server uses ReadStream and WriteStream #136 (#137)
* Server uses streams * Bruh
Configuration menu - View commit details
-
Copy full SHA for 4542ee1 - Browse repository at this point
Copy the full SHA 4542ee1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 630332b - Browse repository at this point
Copy the full SHA 630332bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0236436 - Browse repository at this point
Copy the full SHA 0236436View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4dd2d96 - Browse repository at this point
Copy the full SHA 4dd2d96View commit details -
[protocolv2] Init always exists (#159)
* I -> Input, O -> Output, E -> Err * Update types * Update implementation * Update tests * Misc changes * fix checking init instead of input
Configuration menu - View commit details
-
Copy full SHA for 528f304 - Browse repository at this point
Copy the full SHA 528f304View commit details -
Configuration menu - View commit details
-
Copy full SHA for acadffe - Browse repository at this point
Copy the full SHA acadffeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fc5e25 - Browse repository at this point
Copy the full SHA 5fc5e25View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8bed4e3 - Browse repository at this point
Copy the full SHA 8bed4e3View commit details -
[protocolv2] swap WriteStream's waitForCloseRequest promise with call…
…back style onCloseRequest (#164)
Configuration menu - View commit details
-
Copy full SHA for 1d01d20 - Browse repository at this point
Copy the full SHA 1d01d20View commit details -
[protocolv2] Implement close requests (#165)
* [protocolv2] Implement close requests * Add some more checks * Add comments on for control flags * Revert "Add some more checks" This reverts commit 20e1c10.
Configuration menu - View commit details
-
Copy full SHA for 0e306ec - Browse repository at this point
Copy the full SHA 0e306ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d99095 - Browse repository at this point
Copy the full SHA 8d99095View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c3995c - Browse repository at this point
Copy the full SHA 9c3995cView commit details -
[protocolv2] Make ReadStream always emit Result values (#172)
Configuration menu - View commit details
-
Copy full SHA for 5598c69 - Browse repository at this point
Copy the full SHA 5598c69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f30c9a - Browse repository at this point
Copy the full SHA 7f30c9aView commit details -
Swap stream abort with stream close bits
Old stream closures are more akin to what abort is supposed to do so it's better to swap them to maintain better compatibility #175 (comment)
Configuration menu - View commit details
-
Copy full SHA for ab42557 - Browse repository at this point
Copy the full SHA ab42557View commit details -
- Used extra instead of extras - Didn't inforce literal values - No way of validating error results properly
Configuration menu - View commit details
-
Copy full SHA for f53f93c - Browse repository at this point
Copy the full SHA f53f93cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2945b7e - Browse repository at this point
Copy the full SHA 2945b7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e06bef8 - Browse repository at this point
Copy the full SHA e06bef8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29e5696 - Browse repository at this point
Copy the full SHA 29e5696View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03ab0c3 - Browse repository at this point
Copy the full SHA 03ab0c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9b32bd - Browse repository at this point
Copy the full SHA b9b32bdView commit details -
[protocolv2] Handle invalid requests and internal server errors (#203)
## Why Clients can send invalid requests for many reasons, most commonly due to backwards incompatible server changes, server should handle those and send back a stream abort with it. ## What changed - Introduced `INTERNAL_RIVER_ERROR` code since some of the errors are invariant violations on the server - Split out stream request validation from stream handling - When we see a bad request, we send `INVALID_REQUEST` code with an abort bit - Made tracing `createHandlerSpan` accept tracing fields explicitly instead of a transport message some more changes that I'll note inline
Configuration menu - View commit details
-
Copy full SHA for 2d08c4c - Browse repository at this point
Copy the full SHA 2d08c4cView commit details -
[protocolv2] Ignore follow up messages to a stream after server abort…
…s it (#204) ## Why When the server aborts a stream (due to invalid request or explicit abort) the client send more messages before it gets the abort. We should make sure this doesn't lead to errors and unnecessary follow up responses. ## What changed Keep an LRU of aborted streams, if a new message comes in for a stream in our set, we simply ignore the message.
Configuration menu - View commit details
-
Copy full SHA for 68c5072 - Browse repository at this point
Copy the full SHA 68c5072View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e31350 - Browse repository at this point
Copy the full SHA 3e31350View commit details -
Configuration menu - View commit details
-
Copy full SHA for 714f0dc - Browse repository at this point
Copy the full SHA 714f0dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57a0656 - Browse repository at this point
Copy the full SHA 57a0656View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12258b7 - Browse repository at this point
Copy the full SHA 12258b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 551cf52 - Browse repository at this point
Copy the full SHA 551cf52View commit details -
Configuration menu - View commit details
-
Copy full SHA for e79b6b6 - Browse repository at this point
Copy the full SHA e79b6b6View commit details
Commits on Jun 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9209740 - Browse repository at this point
Copy the full SHA 9209740View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1545321 - Browse repository at this point
Copy the full SHA 1545321View commit details
Commits on Jul 5, 2024
-
[protocolv2] Allow listening for close on WriteStream (#226)
## Why I ended up needing this in river-babel, it's probably a useful API to have ## What changed - Added `WriteStream.onClose` - Unrelated: Made `WriteStream.close` lose reference to `onCloseRequest` listeners and unset `write` function
Configuration menu - View commit details
-
Copy full SHA for 029fe37 - Browse repository at this point
Copy the full SHA 029fe37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b9c39d - Browse repository at this point
Copy the full SHA 4b9c39dView commit details
Commits on Jul 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7ac0c0d - Browse repository at this point
Copy the full SHA 7ac0c0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 46555da - Browse repository at this point
Copy the full SHA 46555daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e76796 - Browse repository at this point
Copy the full SHA 4e76796View commit details
Commits on Jul 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5e8d8a8 - Browse repository at this point
Copy the full SHA 5e8d8a8View commit details -
[protocolv2] Make server backwards compatible for now (#230)
## Why It's easier to roll out this way. ## What changed - Added `protocolVersion` to transport - Added allow-list for accepted protocol versions - Use `protocolVersion` in the server router to determine how we should deal with closes and aborts
Configuration menu - View commit details
-
Copy full SHA for 052741c - Browse repository at this point
Copy the full SHA 052741cView commit details
Commits on Jul 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8295845 - Browse repository at this point
Copy the full SHA 8295845View commit details -
[protocolv2] Fix passing input as first message being backwards incom…
…patible (#236) ## Why In v1.1 sometimes the first message is not `init`, but instead it's the `input`. Let's handle that. ## What changed If we get an `init` that's not matching what we expect, we'll check if the client is on v1.1 and sent us an `input` as a first message, then we'll pass the first message as `input` and treat `init` as an empty object (which is what the first pass of requiring `init` for `stream` and `upload` be). ## Versioning - [ ] Breaking protocol change - [ ] Breaking ts/js API change <!-- Kind reminder to add tests and updated documentation if needed -->
Configuration menu - View commit details
-
Copy full SHA for 577cc66 - Browse repository at this point
Copy the full SHA 577cc66View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86b6d70 - Browse repository at this point
Copy the full SHA 86b6d70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ec651c - Browse repository at this point
Copy the full SHA 6ec651cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98536f5 - Browse repository at this point
Copy the full SHA 98536f5View commit details
Commits on Jul 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 57a1b1f - Browse repository at this point
Copy the full SHA 57a1b1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36b78a0 - Browse repository at this point
Copy the full SHA 36b78a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2cb04f - Browse repository at this point
Copy the full SHA b2cb04fView commit details
Commits on Jul 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c70e8b0 - Browse repository at this point
Copy the full SHA c70e8b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4357884 - Browse repository at this point
Copy the full SHA 4357884View commit details -
Configuration menu - View commit details
-
Copy full SHA for 944ea30 - Browse repository at this point
Copy the full SHA 944ea30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b55481 - Browse repository at this point
Copy the full SHA 9b55481View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b50c64 - Browse repository at this point
Copy the full SHA 7b50c64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e42e02 - Browse repository at this point
Copy the full SHA 7e42e02View commit details
Commits on Jul 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5cb0ede - Browse repository at this point
Copy the full SHA 5cb0edeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 93b4aa9 - Browse repository at this point
Copy the full SHA 93b4aa9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 632e212 - Browse repository at this point
Copy the full SHA 632e212View commit details -
Configuration menu - View commit details
-
Copy full SHA for e64d96f - Browse repository at this point
Copy the full SHA e64d96fView commit details
Commits on Jul 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 60a18b6 - Browse repository at this point
Copy the full SHA 60a18b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8782852 - Browse repository at this point
Copy the full SHA 8782852View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93479b4 - Browse repository at this point
Copy the full SHA 93479b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 493babe - Browse repository at this point
Copy the full SHA 493babeView commit details
Commits on Jul 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for adbcc1b - Browse repository at this point
Copy the full SHA adbcc1bView commit details
Commits on Jul 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0df2852 - Browse repository at this point
Copy the full SHA 0df2852View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8227782 - Browse repository at this point
Copy the full SHA 8227782View commit details
Commits on Aug 1, 2024
-
Got some comments on streams being complicated, so this is a take on simplified API. - Less methods and states that people need to understand - Merge interfaces into a single object (i.e. a `stream` call would have both read and write capabilities on the same object)
Configuration menu - View commit details
-
Copy full SHA for 667b6cb - Browse repository at this point
Copy the full SHA 667b6cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 251758b - Browse repository at this point
Copy the full SHA 251758bView commit details -
[protocolv2] Use new simpler readable and writable interfaces (#250)
## Why Follow up on #249 to actually use the new interfaces. Removed extra refactor done in #249 that merges the interfaces as that proved to be a challenging API (un-yak-shave 🙅 🐃) ## What changed - Removed close requests (mostly cherry-picked from #248) - Otherwise a simple swapping out of the interfaces ## Versioning - [ ] Breaking protocol change - [ ] Breaking ts/js API change <!-- Kind reminder to add tests and updated documentation if needed -->
Configuration menu - View commit details
-
Copy full SHA for bab2aa8 - Browse repository at this point
Copy the full SHA bab2aa8View commit details -
[protocolv2] Rename reader to readable and writer to writable (#251)
Just a simple follow up to #250
Configuration menu - View commit details
-
Copy full SHA for 87dd2de - Browse repository at this point
Copy the full SHA 87dd2deView commit details
Commits on Aug 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d44ef6b - Browse repository at this point
Copy the full SHA d44ef6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97f1479 - Browse repository at this point
Copy the full SHA 97f1479View commit details
Commits on Aug 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c173fc0 - Browse repository at this point
Copy the full SHA c173fc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed0c9a1 - Browse repository at this point
Copy the full SHA ed0c9a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3d808b - Browse repository at this point
Copy the full SHA f3d808bView commit details
Commits on Aug 8, 2024
-
Partially to match gRPC nomeclature and to avoid confusion with AbortSignal/AbortController
Configuration menu - View commit details
-
Copy full SHA for a7472d1 - Browse repository at this point
Copy the full SHA a7472d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb98bb1 - Browse repository at this point
Copy the full SHA eb98bb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d22a7d1 - Browse repository at this point
Copy the full SHA d22a7d1View commit details
Commits on Aug 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c4bdf59 - Browse repository at this point
Copy the full SHA c4bdf59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f9959e - Browse repository at this point
Copy the full SHA 5f9959eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 831ebb7 - Browse repository at this point
Copy the full SHA 831ebb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 829097b - Browse repository at this point
Copy the full SHA 829097bView commit details
Commits on Aug 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 531c613 - Browse repository at this point
Copy the full SHA 531c613View commit details