Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit status events when transport status changes #184

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Emit status events when transport status changes #184

merged 1 commit into from
Jun 11, 2024

Conversation

masad-frost
Copy link
Member

@masad-frost masad-frost commented Jun 11, 2024 •
edited
Loading

Why

I need this in #127, thought I'd pull it out. Doesn't hurt to have generally.

What changed

  • state is now private and called status
  • emit status when status changes

Versioning

  • Breaking protocol change
  • Breaking ts/js API change
    • public state on transport is now getStatus()

@masad-frost masad-frost requested a review from a team as a code owner June 11, 2024 02:49
@masad-frost masad-frost requested review from jackyzha0 and removed request for a team June 11, 2024 02:49
This was referenced Jun 11, 2024
Merged
Merged
@masad-frost masad-frost merged commit c1fb454 into main Jun 11, 2024
3 checks passed
@masad-frost masad-frost deleted the fm-transport-status-event branch June 11, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackyzha0 jackyzha0 jackyzha0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@masad-frost @jackyzha0