simplify proxy, move seq check to no session path #233

jackyzha0 · 2024-07-12T08:02:35Z

Why

we hit codepaths where we hit a hard reconnect route and skip over the check where we make sure that the client isn't asking for a session we don't have

simplify ws<>uds proxy to not need to introspect the messages
fix the else check in the server so that we properly check clientNextSentSeq > 0 || clientNextExpectedSeq > 0 even if we just went through a hard reconnect
change the transparent reconnect test to actually test the right thing

transport/transport.test.ts

lhchavez · 2024-07-12T17:59:54Z

transport/transport.test.ts

+ expect(oldClientSessionId).not.toBeUndefined();
+ expect(oldServerSessionId).not.toBeUndefined();
+
+ await advanceFakeTimersBySessionGrace();


request: we should also try a reconnect here (that was the OG bug)

other test "reconnecting before grace period ends should leave session intact" should cover this

simplify proxy, move seq check to no session path

1796e3c

jackyzha0 requested a review from a team as a code owner July 12, 2024 08:02

jackyzha0 requested review from Monkatraz, lhchavez and masad-frost and removed request for a team July 12, 2024 08:02

format, lint

975818d

lhchavez reviewed Jul 12, 2024

View reviewed changes

transport/transport.test.ts Show resolved Hide resolved

transport/transport.test.ts Show resolved Hide resolved

jackyzha0 added 3 commits July 12, 2024 09:25

split out idle test

431c649

fix test expectation

190faf0

Merge branch 'main' into jackyzha0/move-client-seq-check-outside

34e5f32

lhchavez approved these changes Jul 12, 2024

View reviewed changes

jackyzha0 merged commit 8add7a9 into main Jul 12, 2024
4 checks passed

jackyzha0 deleted the jackyzha0/move-client-seq-check-outside branch July 12, 2024 18:02