Added WAPM integration into upm #22
Conversation
|
@amasad I think this PR is ready for review :) |
|
@syrusakbary awesome! Excited to see this merged. FYI we have wasmer running on Repl.it here: http://repl.it/languages/wasm |
|
Feedback addressed! I also created this PR updating the Wasmer version on polyglott: replit/polygott#51 |
| util.RunCmd([]string{"wapm", "install"}) | ||
| }, | ||
| Install: func() { | ||
| util.RunCmd([]string{"wapm", "install", "-y"}) |
There was a problem hiding this comment.
I noticed Lock uses wapm install and Install uses wapm install -y. What's the difference? I don't see it mentioned in the docs.
There was a problem hiding this comment.
wapm install -y automatically accepts certificates for signed packages when installing them (and any other input requested from the user).
There was a problem hiding this comment.
sounds like we want wapm install -y in both cases then
There was a problem hiding this comment.
@turbio sounds good! I just updated the PR :)
Loving this! Let me know if there is more feedback that I need to address @turbio @amasad :) |
|
Good afternoon @syrusakbary ! You've probably noticed by now that we've been slow to merge community PRs on polygott. We've decided to focus on giving Repl.it a stable foundation instead of adding features and updating languages. Once we and our community feel comfortable with Repl.it's overall stability, we'll give this change another look. Thank you for contributing! |
Resolves #17
This PR adds WebAssembly WAPM integration into UPM in the simplest way possible.
It's built upon the new version of Wasmer/wapm (0.10.0) with new features in the WAPM CLI required for upm (specifically the commands
wapm addandwapm remove).Because we are using GraphQL to query the data, it should be easy to maintain and ask for more data in the future if we need it so.
Looking forward getting some feedback! :)