feat/flit support #270
Closed
feat/flit support #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdmistman
reviewed
Jun 17, 2024
internal/backends/python/python.go
Outdated
cdmistman
reviewed
Jun 17, 2024
internal/cli/cmds.go
Outdated
| @@ -267,6 +267,11 @@ func runAdd( | |||
| defer span.Finish() | |||
| b := backends.GetBackend(ctx, language) | |||
|
|
|||
| if !b.QuirksCanAddRemove() { | |||
| fmt.Println("This backend does not suppport dependency additions") | |||
There was a problem hiding this comment.
Suggested change
| fmt.Println("This backend does not suppport dependency additions") | |
| fmt.Println("This backend does not suppport dependency addition") |
nit to keep consistent with the other error message
cdmistman
requested changes
Jun 17, 2024
blast-hardcheese
force-pushed
the
dstewart/feat/flit-support
branch
from
f96dafe
to
921f710
Compare
|
A workaround was found for flit. This work can be brought back if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As we continue to expand into the realm of offering better Python package manager support, we're happy to add
flitto upm.What changed
BurntSushi/tomlto 1.4.0python/poetry.goandpython/pip.goto go along withpython/flit.gorequirements.txtadditions where we would take a zero-byterequirements.txtand turn it into\ndepinstead ofdep\nQuirksCannotAddRemoveto supportflit, which does not directly supportaddorremove. In the future, we can or delete frompyproject.tomlTest plan
https://github.com/mwaskom/seaborninto Replitpip install flitto get a compatible version of flitupm install