Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(flake): update build-go-cache for less rebuild #274

Closed
wants to merge 1 commit into from

Conversation

zimbatm
Copy link

@zimbatm zimbatm commented Jul 19, 2024

Why

This is a small developer UX issue. In some cases, Nix would rebuild instead of fetching the result from the binary cache.

What changed

numtide/build-go-cache#9

Thanks to katexochen for fixing this issue.

Test plan

Describe what you did to test this change to a level of detail that allows your reviewer to test it

The latest version includes
numtide/build-go-cache#9 that fixes a case where
the code would get rebuilt unnecessarily.

Thanks to katexochen for fixing this issue.
@zimbatm zimbatm requested a review from a team as a code owner July 19, 2024 11:05
@zimbatm zimbatm requested review from airportyh and removed request for a team July 19, 2024 11:05
@katexochen
Copy link

@zimbatm there is actually a workaround in place to prevent the rebuilds in another way (the comment pointed me to the problem in the first place):

upm/nix/upm/default.nix

Lines 16 to 20 in 91c21f5

# FIXME: Somehow we get cache invalidation everytime if we don't do this, also it uses a source filter
src = runCommand "go-mod" {} ''
install -D ${../../go.mod} $out/go.mod
install -D ${../../go.sum} $out/go.sum
'';

This could be removed now. :)

@blast-hardcheese
Copy link
Collaborator

Based on the conversation here it seems this is not necessary, closing this out for now but please feel free to follow up if I misunderstood. Thank you!

@zimbatm zimbatm deleted the update-build-go-cache branch August 13, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants