Release 5.12.0 #336
Release 5.12.0 #336
Conversation
* EPMRPP-89264 code style reformat
EPMRPP-89225 || EPMRPP-89226 || EPMRPP-89227 || Describe security in api doc
* EPMRPP-89102 || Update libs version * EPMRPP-89102 || Update libs
EPMRPP-84831 || Update Gradle build script
…horization into rc/5.11.0 � Conflicts: � build.gradle � src/main/java/com/epam/reportportal/auth/AuthSuccessHandler.java
Release 5.11.0
…horization into EPMRPP-89703-lib-merge � Conflicts: � build.gradle
EPMRPP-89703 || Update libs with one merged
EPMRPP-90182 || Update JDBC Driver to the latest
# Conflicts: # build.gradle
Merge hotfix/5.11.1
…ReportPortal deployed under path (#317)
EPMRPP-87663 || Add name attribute mode to LDAP integration
…lue to 'NO' in LDAP integration (#324)
EPMRPP-90137 || Add ldap connection timeout in 3s
EPMRPP-90137 || Change ldap timeout type
EPMRPP-90137 || Change ad timeout
EPMRPP-94552 || Fix full name builder
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
reviewdog
src/main/java/com/epam/reportportal/auth/TokenServicesFacade.java|45 col 38| Member name 'oAuth2RequestFactory' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]$'.
src/main/java/com/epam/reportportal/auth/TokenServicesFacade.java|48 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/TokenServicesFacade.java|62 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/TokenServicesFacade.java|70 col 25| Abbreviation in name 'createOAuth2Request' must contain no more than '1' consecutive capital letters.
src/main/java/com/epam/reportportal/auth/integration/converter/ActiveDirectoryConverter.java|21 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.ActiveDirectoryResource' import. Should be before 'com.epam.ta.reportportal.entity.integration.Integration'.
src/main/java/com/epam/reportportal/auth/integration/converter/SamlConverter.java|37 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/converter/SamlConverter.java|86| Line is longer than 100 characters (found 142).
src/main/java/com/epam/reportportal/auth/integration/converter/LdapConverter.java|24 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.LdapAttributes' import. Should be before 'com.epam.ta.reportportal.entity.integration.Integration'.
src/main/java/com/epam/reportportal/auth/integration/converter/LdapConverter.java|25 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.LdapResource' import. Should be before 'com.epam.ta.reportportal.entity.integration.Integration'.
src/main/java/com/epam/reportportal/auth/integration/converter/LdapConverter.java|26 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.SynchronizationAttributesResource' import. Should be before 'com.epam.ta.reportportal.entity.integration.Integration'.
src/main/java/com/epam/reportportal/auth/integration/converter/LdapConverter.java|27 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.ta.reportportal.entity.integration.Integration'.
src/main/java/com/epam/reportportal/auth/integration/converter/OAuthRestrictionConverter.java|23 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.settings.OAuthRegistrationResource' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistrationRestriction'.
src/main/java/com/epam/reportportal/auth/integration/converter/OAuthRestrictionConverter.java|40| Line is longer than 100 characters (found 137).
src/main/java/com/epam/reportportal/auth/integration/converter/OAuthRestrictionConverter.java|41| Line is longer than 100 characters (found 135).
src/main/java/com/epam/reportportal/auth/integration/converter/OAuthRestrictionConverter.java|46| Line is longer than 100 characters (found 163).
src/main/java/com/epam/reportportal/auth/integration/converter/OAuthRegistrationConverters.java|53 col 28| Local variable name 'oAuthRegistrationScope' must match pattern '^a-z?$'.
src/main/java/com/epam/reportportal/auth/integration/converter/OAuthRegistrationConverters.java|101| Line is longer than 100 characters (found 162).
src/main/java/com/epam/reportportal/auth/integration/github/GitHubTokenServices.java|24 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.settings.OAuthRegistrationResource' import. Should be before 'com.epam.ta.reportportal.commons.ReportPortalUser'.
src/main/java/com/epam/reportportal/auth/integration/github/GitHubTokenServices.java|47 col 53| Member name 'oAuthRegistrationSupplier' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]$'.
src/main/java/com/epam/reportportal/auth/integration/github/GitHubTokenServices.java|50 col 43| Parameter name 'oAuthRegistrationSupplier' must match pattern '^a-z?$'.
src/main/java/com/epam/reportportal/auth/integration/github/GitHubTokenServices.java|61 col 31| Local variable name 'oAuthRegistrationResource' must match pattern '^a-z?$'.
src/main/java/com/epam/reportportal/auth/integration/github/GitHubTokenServices.java|101 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/github/GithubEndpoint.java|23 col 1| Wrong lexicographical order for 'com.epam.reportportal.auth.OperationCompletionRS' import. Should be before 'com.epam.reportportal.rules.exception.ErrorType'.
src/main/java/com/epam/reportportal/auth/integration/github/GithubEndpoint.java|50 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/github/GithubOauthProvider.java|36| Line is longer than 100 characters (found 589).
src/main/java/com/epam/reportportal/auth/integration/github/GithubOauthProvider.java|44 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/github/GitHubClient.java|83 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/github/ExternalOauth2TokenConverter.java|47 col 26| Local variable name 'oAuth2Authentication' must match pattern '^a-z?$'.
src/main/java/com/epam/reportportal/auth/integration/github/GitHubUserReplicator.java|38 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.util.PersonalProjectService'.
src/main/java/com/epam/reportportal/auth/integration/github/GitHubUserReplicator.java|69 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/handler/CreateAuthIntegrationHandler.java|21 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.AbstractAuthResource' import. Should be before 'com.epam.ta.reportportal.commons.ReportPortalUser'.
src/main/java/com/epam/reportportal/auth/integration/handler/CreateAuthIntegrationHandler.java|22 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.ta.reportportal.commons.ReportPortalUser'.
src/main/java/com/epam/reportportal/auth/integration/handler/CreateAuthIntegrationHandler.java|23 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.settings.OAuthRegistrationResource' import. Should be before 'com.epam.ta.reportportal.commons.ReportPortalUser'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/CreateAuthIntegrationHandlerImpl.java|31 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/CreateAuthIntegrationHandlerImpl.java|32 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/CreateAuthIntegrationHandlerImpl.java|33 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.AbstractAuthResource' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/CreateAuthIntegrationHandlerImpl.java|34 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/CreateAuthIntegrationHandlerImpl.java|35 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.settings.OAuthRegistrationResource' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/CreateAuthIntegrationHandlerImpl.java|49 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/CreateAuthIntegrationHandlerImpl.java|96 col 23| Local variable name 'oAuthRegistration' must match pattern '^a-z?$'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetSamlIntegrationsStrategy.java|12 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetSamlIntegrationsStrategy.java|13 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetSamlIntegrationsStrategy.java|14 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.AbstractAuthResource' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetLdapStrategy.java|26 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetLdapStrategy.java|27 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetLdapStrategy.java|28 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.AbstractLdapResource' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetLdapStrategy.java|29 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.LdapResource' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/DeleteAuthIntegrationHandlerImpl.java|31 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/DeleteAuthIntegrationHandlerImpl.java|32 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/DeleteAuthIntegrationHandlerImpl.java|33 col 1| Wrong lexicographical order for 'com.epam.reportportal.auth.OperationCompletionRS' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/DeleteAuthIntegrationHandlerImpl.java|50 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/DeleteAuthIntegrationHandlerImpl.java|84 col 23| Local variable name 'oAuthRegistration' must match pattern '^a-z?$'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetAuthIntegrationHandlerImpl.java|31 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.reportportal.rules.exception.ReportPortalException'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetAuthIntegrationHandlerImpl.java|32 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.AbstractAuthResource' import. Should be before 'com.epam.reportportal.rules.exception.ReportPortalException'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetAuthIntegrationHandlerImpl.java|33 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.settings.OAuthRegistrationResource' import. Should be before 'com.epam.reportportal.rules.exception.ReportPortalException'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetAuthIntegrationHandlerImpl.java|83| Line is longer than 100 characters (found 105).
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/ActiveDirectoryIntegrationStrategy.java|26 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.ta.reportportal.entity.integration.Integration'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/LdapIntegrationStrategy.java|27 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.ta.reportportal.entity.integration.Integration'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/SamlIntegrationStrategy.java|34 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationTypeDetails'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/SamlIntegrationStrategy.java|35 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationTypeDetails'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/SamlIntegrationStrategy.java|36 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationTypeDetails'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/SamlIntegrationStrategy.java|61 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/AuthIntegrationStrategy.java|25 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/AuthIntegrationStrategy.java|26 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/AuthIntegrationStrategy.java|27 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/AuthIntegrationStrategy.java|41 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/AuthIntegrationStrategy.java|51 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/AuthIntegrationStrategy.java|64 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetActiveDirectoryStrategy.java|26 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetActiveDirectoryStrategy.java|27 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetActiveDirectoryStrategy.java|28 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.ActiveDirectoryResource' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/AbstractUserReplicator.java|52 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/parameter/ParameterUtils.java|31 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.ta.reportportal.entity.integration.Integration'.
src/main/java/com/epam/reportportal/auth/integration/parameter/ParameterUtils.java|69 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/parameter/SamlParameter.java|24 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationParams'.
src/main/java/com/epam/reportportal/auth/integration/parameter/SamlParameter.java|25 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationParams'.
src/main/java/com/epam/reportportal/auth/integration/parameter/SamlParameter.java|26 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationParams'.
src/main/java/com/epam/reportportal/auth/integration/parameter/SamlParameter.java|80 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/parameter/SamlParameter.java|99 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/parameter/SamlParameter.java|114 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/parameter/LdapParameter.java|80 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/parameter/LdapParameter.java|90 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/parameter/LdapParameter.java|112 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/parameter/LdapParameter.java|132 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/saml/SamlUserReplicator.java|40 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.user.UserType'.
src/main/java/com/epam/reportportal/auth/integration/saml/SamlUserReplicator.java|42 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.util.PersonalProjectService'.
src/main/java/com/epam/reportportal/auth/integration/saml/ReportPortalSamlAuthentication.java|51 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/saml/ReportPortalSamlAuthentication.java|64 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/validator/duplicate/UniqueNameGlobalIntegrationValidator.java|22 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.integration.Integration'.
src/main/java/com/epam/reportportal/auth/integration/validator/request/UpdateAuthRequestValidator.java|25 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.reportportal.rules.exception.ErrorType'.
src/main/java/com/epam/reportportal/auth/integration/validator/request/SamlUpdateAuthRequestValidator.java|27 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.reportportal.rules.exception.ErrorType'.
src/main/java/com/epam/reportportal/auth/util/RequestUtil.java|34 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/util/CertificationUtil.java|43 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/util/CertificationUtil.java|60 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/oauth/OAuthProviderFactory.java|22 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/oauth/OAuthProviderFactory.java|23 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/oauth/OAuthProviderFactory.java|24 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.settings.OAuthRegistrationResource' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/oauth/OAuthProviderFactory.java|30 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/oauth/OAuthProviderFactory.java|30 col 35| Abbreviation in name 'fillOAuthRegistration' must contain no more than '1' consecutive capital letters.
src/main/java/com/epam/reportportal/auth/oauth/OAuthProvider.java|31 col 23| Abbreviation in name 'OAuthProvider' must contain no more than '1' consecutive capital letters.
src/main/java/com/epam/reportportal/auth/oauth/OAuthProvider.java|48 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/oauth/OAuthProvider.java|58 col 40| Abbreviation in name 'getOAuthRestOperations' must contain no more than '1' consecutive capital letters.
src/main/java/com/epam/reportportal/auth/OAuthSuccessHandler.java|23 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.reportportal.rules.exception.ReportPortalException'.
src/main/java/com/epam/reportportal/auth/OAuthSuccessHandler.java|51 col 26| Local variable name 'oAuth2Authentication' must match pattern '^a-z?$'.
src/main/java/com/epam/reportportal/auth/config/SpringDocConfiguration.java|49| Summary javadoc is missing.
src/main/java/com/epam/reportportal/auth/config/SpringDocConfiguration.java|73 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/config/SpringDocConfiguration.java|74 col 18| Abbreviation in name 'openAPI' must contain no more than '1' consecutive capital letters.
src/main/java/com/epam/reportportal/auth/config/SpringDocConfiguration.java|100 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/config/SpringDocConfiguration.java|108 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/config/SecurityConfiguration.java|34 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.ServerSettings'.
src/main/java/com/epam/reportportal/auth/config/SecurityConfiguration.java|35 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.ServerSettings'.
src/main/java/com/epam/reportportal/auth/config/SecurityConfiguration.java|97 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/config/SecurityConfiguration.java|112 col 5| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/config/SecurityConfiguration.java|180 col 5| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/config/SecurityConfiguration.java|188 col 5| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/config/SecurityConfiguration.java|200 col 5| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/config/SecurityConfiguration.java|218 col 5| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/config/SecurityConfiguration.java|300 col 5| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/config/SecurityConfiguration.java|320 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/config/SecurityConfiguration.java|397 col 5| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/config/SecurityConfiguration.java|406 col 5| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/config/SecurityConfiguration.java|414 col 5| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/config/SecurityConfiguration.java|422 col 5| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/config/SecurityConfiguration.java|439 col 5| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/config/SecurityConfiguration.java|454 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/config/saml/SamlServiceProviderBeanConfiguration.java|69 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/config/saml/SamlServiceProviderConfiguration.java|186 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/config/AuthIntegrationConfig.java|54 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/config/AuthIntegrationConfig.java|64 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/config/AuthIntegrationConfig.java|71| Line is longer than 100 characters (found 104).
src/main/java/com/epam/reportportal/auth/event/UiAuthenticationSuccessEventHandler.java|24 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.user.User'.
src/main/java/com/epam/reportportal/auth/event/UiAuthenticationSuccessEventHandler.java|26 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.util.PersonalProjectService'.
src/main/java/com/epam/reportportal/auth/event/UiAuthenticationSuccessEventHandler.java|56 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/event/UiAuthenticationFailureEventHandler.java|51 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/event/UiAuthenticationFailureEventHandler.java|69 col 12| Abbreviation in name 'clientIP' must contain no more than '1' consecutive capital letters.
src/main/java/com/epam/reportportal/auth/event/UiAuthenticationFailureEventHandler.java|74 col 18| Abbreviation in name 'getClientIP' must contain no more than '1' consecutive capital letters.
src/main/java/com/epam/reportportal/auth/store/MutableClientRegistrationRepository.java|25 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/store/MutableClientRegistrationRepository.java|36 col 45| Member name 'oAuthRegistrationRepository' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
src/main/java/com/epam/reportportal/auth/store/MutableClientRegistrationRepository.java|40 col 35| Parameter name 'oAuthRegistrationRepository' must match pattern '^a-z?$'.
src/main/java/com/epam/reportportal/auth/store/MutableClientRegistrationRepository.java|54 col 38| Abbreviation in name 'findOAuthRegistrationById' must contain no more than '1' consecutive capital letters.
src/main/java/com/epam/reportportal/auth/OperationCompletionRS.java|23| First sentence of Javadoc is missing an ending period.
src/main/java/com/epam/reportportal/auth/OperationCompletionRS.java|29 col 14| Abbreviation in name 'OperationCompletionRS' must contain no more than '1' consecutive capital letters.
| * @param id {@link OAuthRegistration#id} | ||
| * @return Built {@link OAuthRegistrationResource} | ||
| */ | ||
| public Optional<OAuthRegistrationResource> loadOAuthRegistration(String id) { |
There was a problem hiding this comment.
Abbreviation in name 'loadOAuthRegistration' must contain no more than '1' consecutive capital letters.
| } | ||
| }).orElseGet(BaseOAuth2ProtectedResourceDetails::new); | ||
| private static BaseOAuth2ProtectedResourceDetails getOauth2ProtectedResourceDetails( | ||
| OAuthRegistrationResource oAuthRegistrationResource) { |
| @Override | ||
| protected void handle(HttpServletRequest request, HttpServletResponse response, Authentication authentication) throws IOException { | ||
| OAuth2AccessToken token = getToken(authentication); | ||
| public AuthSuccessHandler(Provider<TokenServicesFacade> tokenServicesFacade, |
There was a problem hiding this comment.
Missing a Javadoc comment.
| import com.epam.ta.reportportal.exception.ReportPortalException; | ||
| import com.epam.ta.reportportal.ws.model.ErrorType; | ||
| import com.epam.reportportal.rules.exception.ReportPortalException; | ||
| import com.epam.reportportal.rules.exception.ErrorType; |
There was a problem hiding this comment.
Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.reportportal.rules.exception.ReportPortalException'.
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.epam.reportportal.auth.model; |
There was a problem hiding this comment.
'package' should be separated from previous line.
| @ResponseBody | ||
| @ResponseStatus(HttpStatus.OK) | ||
| @Operation(summary = "Creates/Updates OAuth Integration Settings") | ||
| public OAuthRegistrationResource updateOAuthSettings( |
There was a problem hiding this comment.
Abbreviation in name 'updateOAuthSettings' must contain no more than '1' consecutive capital letters.
| @ResponseBody | ||
| @ResponseStatus(HttpStatus.OK) | ||
| @Operation(summary = "Deletes OAuth Integration Settings") | ||
| public OperationCompletionRS deleteOAuthSetting(@PathVariable("authId") String oauthProviderId) { |
There was a problem hiding this comment.
Abbreviation in name 'deleteOAuthSetting' must contain no more than '1' consecutive capital letters.
| @ResponseBody | ||
| @ResponseStatus(HttpStatus.OK) | ||
| @Operation(summary = "Returns OAuth Server Settings") | ||
| public Map<String, OAuthRegistrationResource> getOAuthSettings() { |
There was a problem hiding this comment.
Abbreviation in name 'getOAuthSettings' must contain no more than '1' consecutive capital letters.
| @ResponseBody | ||
| @ResponseStatus(HttpStatus.OK) | ||
| @Operation(summary = "Returns OAuth Server Settings") | ||
| public ResponseEntity<OAuthRegistrationResource> getOAuthSettings( |
There was a problem hiding this comment.
Abbreviation in name 'getOAuthSettings' must contain no more than '1' consecutive capital letters.
| public class SsoEndpoint { | ||
|
|
||
| @RequestMapping(value = { "/sso/me", "/sso/user" }, method = { GET, POST }) | ||
| public Map<String, Object> user(Authentication user) { | ||
| @RequestMapping(value = {"/sso/me", "/sso/user"}, method = {GET, POST}) |
There was a problem hiding this comment.
Missing a Javadoc comment.
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
reviewdog
src/main/java/com/epam/reportportal/auth/util/RequestUtil.java|34 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/AbstractUserReplicator.java|52 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/parameter/LdapParameter.java|80 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/parameter/LdapParameter.java|90 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/parameter/LdapParameter.java|112 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/parameter/LdapParameter.java|132 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/parameter/SamlParameter.java|24 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationParams'.
src/main/java/com/epam/reportportal/auth/integration/parameter/SamlParameter.java|25 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationParams'.
src/main/java/com/epam/reportportal/auth/integration/parameter/SamlParameter.java|26 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationParams'.
src/main/java/com/epam/reportportal/auth/integration/parameter/SamlParameter.java|80 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/parameter/SamlParameter.java|99 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/parameter/SamlParameter.java|114 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/parameter/ParameterUtils.java|31 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.ta.reportportal.entity.integration.Integration'.
src/main/java/com/epam/reportportal/auth/integration/parameter/ParameterUtils.java|69 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/saml/SamlUserReplicator.java|40 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.user.UserType'.
src/main/java/com/epam/reportportal/auth/integration/saml/SamlUserReplicator.java|42 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.util.PersonalProjectService'.
src/main/java/com/epam/reportportal/auth/integration/saml/ReportPortalSamlAuthentication.java|51 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/saml/ReportPortalSamlAuthentication.java|64 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/DeleteAuthIntegrationHandlerImpl.java|31 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/DeleteAuthIntegrationHandlerImpl.java|32 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/DeleteAuthIntegrationHandlerImpl.java|33 col 1| Wrong lexicographical order for 'com.epam.reportportal.auth.OperationCompletionRS' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/DeleteAuthIntegrationHandlerImpl.java|50 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/DeleteAuthIntegrationHandlerImpl.java|84 col 23| Local variable name 'oAuthRegistration' must match pattern '^a-z?$'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetSamlIntegrationsStrategy.java|12 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetSamlIntegrationsStrategy.java|13 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetSamlIntegrationsStrategy.java|14 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.AbstractAuthResource' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/ActiveDirectoryIntegrationStrategy.java|26 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.ta.reportportal.entity.integration.Integration'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/LdapIntegrationStrategy.java|27 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.ta.reportportal.entity.integration.Integration'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/SamlIntegrationStrategy.java|34 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationTypeDetails'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/SamlIntegrationStrategy.java|35 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationTypeDetails'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/SamlIntegrationStrategy.java|36 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationTypeDetails'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/SamlIntegrationStrategy.java|61 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/AuthIntegrationStrategy.java|25 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/AuthIntegrationStrategy.java|26 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/AuthIntegrationStrategy.java|27 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/AuthIntegrationStrategy.java|41 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/AuthIntegrationStrategy.java|51 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/strategy/AuthIntegrationStrategy.java|64 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/CreateAuthIntegrationHandlerImpl.java|31 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/CreateAuthIntegrationHandlerImpl.java|32 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/CreateAuthIntegrationHandlerImpl.java|33 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.AbstractAuthResource' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/CreateAuthIntegrationHandlerImpl.java|34 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/CreateAuthIntegrationHandlerImpl.java|35 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.settings.OAuthRegistrationResource' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/CreateAuthIntegrationHandlerImpl.java|49 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/CreateAuthIntegrationHandlerImpl.java|96 col 23| Local variable name 'oAuthRegistration' must match pattern '^a-z?$'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetActiveDirectoryStrategy.java|26 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetActiveDirectoryStrategy.java|27 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetActiveDirectoryStrategy.java|28 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.ActiveDirectoryResource' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetLdapStrategy.java|26 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetLdapStrategy.java|27 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetLdapStrategy.java|28 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.AbstractLdapResource' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetLdapStrategy.java|29 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.LdapResource' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetAuthIntegrationHandlerImpl.java|31 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.reportportal.rules.exception.ReportPortalException'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetAuthIntegrationHandlerImpl.java|32 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.AbstractAuthResource' import. Should be before 'com.epam.reportportal.rules.exception.ReportPortalException'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetAuthIntegrationHandlerImpl.java|33 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.settings.OAuthRegistrationResource' import. Should be before 'com.epam.reportportal.rules.exception.ReportPortalException'.
src/main/java/com/epam/reportportal/auth/integration/handler/impl/GetAuthIntegrationHandlerImpl.java|83| Line is longer than 100 characters (found 105).
src/main/java/com/epam/reportportal/auth/integration/handler/CreateAuthIntegrationHandler.java|21 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.AbstractAuthResource' import. Should be before 'com.epam.ta.reportportal.commons.ReportPortalUser'.
src/main/java/com/epam/reportportal/auth/integration/handler/CreateAuthIntegrationHandler.java|22 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.ta.reportportal.commons.ReportPortalUser'.
src/main/java/com/epam/reportportal/auth/integration/handler/CreateAuthIntegrationHandler.java|23 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.settings.OAuthRegistrationResource' import. Should be before 'com.epam.ta.reportportal.commons.ReportPortalUser'.
src/main/java/com/epam/reportportal/auth/integration/converter/LdapConverter.java|24 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.LdapAttributes' import. Should be before 'com.epam.ta.reportportal.entity.integration.Integration'.
src/main/java/com/epam/reportportal/auth/integration/converter/LdapConverter.java|25 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.LdapResource' import. Should be before 'com.epam.ta.reportportal.entity.integration.Integration'.
src/main/java/com/epam/reportportal/auth/integration/converter/LdapConverter.java|26 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.SynchronizationAttributesResource' import. Should be before 'com.epam.ta.reportportal.entity.integration.Integration'.
src/main/java/com/epam/reportportal/auth/integration/converter/LdapConverter.java|27 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.ta.reportportal.entity.integration.Integration'.
src/main/java/com/epam/reportportal/auth/integration/converter/OAuthRestrictionConverter.java|23 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.settings.OAuthRegistrationResource' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistrationRestriction'.
src/main/java/com/epam/reportportal/auth/integration/converter/OAuthRestrictionConverter.java|40| Line is longer than 100 characters (found 137).
src/main/java/com/epam/reportportal/auth/integration/converter/OAuthRestrictionConverter.java|41| Line is longer than 100 characters (found 135).
src/main/java/com/epam/reportportal/auth/integration/converter/OAuthRestrictionConverter.java|46| Line is longer than 100 characters (found 163).
src/main/java/com/epam/reportportal/auth/integration/converter/SamlConverter.java|37 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.ta.reportportal.entity.integration.IntegrationType'.
src/main/java/com/epam/reportportal/auth/integration/converter/SamlConverter.java|86| Line is longer than 100 characters (found 142).
src/main/java/com/epam/reportportal/auth/integration/converter/ActiveDirectoryConverter.java|21 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.ActiveDirectoryResource' import. Should be before 'com.epam.ta.reportportal.entity.integration.Integration'.
src/main/java/com/epam/reportportal/auth/integration/converter/OAuthRegistrationConverters.java|53 col 28| Local variable name 'oAuthRegistrationScope' must match pattern '^a-z?$'.
src/main/java/com/epam/reportportal/auth/integration/converter/OAuthRegistrationConverters.java|101| Line is longer than 100 characters (found 162).
src/main/java/com/epam/reportportal/auth/integration/github/GithubEndpoint.java|23 col 1| Wrong lexicographical order for 'com.epam.reportportal.auth.OperationCompletionRS' import. Should be before 'com.epam.reportportal.rules.exception.ErrorType'.
src/main/java/com/epam/reportportal/auth/integration/github/GithubEndpoint.java|50 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/github/GitHubUserReplicator.java|38 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.util.PersonalProjectService'.
src/main/java/com/epam/reportportal/auth/integration/github/GitHubUserReplicator.java|69 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/github/GitHubClient.java|83 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/github/ExternalOauth2TokenConverter.java|47 col 26| Local variable name 'oAuth2Authentication' must match pattern '^a-z?$'.
src/main/java/com/epam/reportportal/auth/integration/github/GitHubTokenServices.java|24 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.settings.OAuthRegistrationResource' import. Should be before 'com.epam.ta.reportportal.commons.ReportPortalUser'.
src/main/java/com/epam/reportportal/auth/integration/github/GitHubTokenServices.java|47 col 53| Member name 'oAuthRegistrationSupplier' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]$'.
src/main/java/com/epam/reportportal/auth/integration/github/GitHubTokenServices.java|50 col 43| Parameter name 'oAuthRegistrationSupplier' must match pattern '^a-z?$'.
src/main/java/com/epam/reportportal/auth/integration/github/GitHubTokenServices.java|61 col 31| Local variable name 'oAuthRegistrationResource' must match pattern '^a-z?$'.
src/main/java/com/epam/reportportal/auth/integration/github/GitHubTokenServices.java|101 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/github/GithubOauthProvider.java|36| Line is longer than 100 characters (found 589).
src/main/java/com/epam/reportportal/auth/integration/github/GithubOauthProvider.java|44 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/integration/validator/duplicate/UniqueNameGlobalIntegrationValidator.java|22 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.integration.Integration'.
src/main/java/com/epam/reportportal/auth/integration/validator/request/SamlUpdateAuthRequestValidator.java|27 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.reportportal.rules.exception.ErrorType'.
src/main/java/com/epam/reportportal/auth/integration/validator/request/UpdateAuthRequestValidator.java|25 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.integration.auth.UpdateAuthRQ' import. Should be before 'com.epam.reportportal.rules.exception.ErrorType'.
src/main/java/com/epam/reportportal/auth/oauth/OAuthProviderFactory.java|22 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/oauth/OAuthProviderFactory.java|23 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/oauth/OAuthProviderFactory.java|24 col 1| Wrong lexicographical order for 'com.epam.reportportal.model.settings.OAuthRegistrationResource' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/oauth/OAuthProviderFactory.java|30 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/oauth/OAuthProviderFactory.java|30 col 35| Abbreviation in name 'fillOAuthRegistration' must contain no more than '1' consecutive capital letters.
src/main/java/com/epam/reportportal/auth/oauth/OAuthProvider.java|31 col 23| Abbreviation in name 'OAuthProvider' must contain no more than '1' consecutive capital letters.
src/main/java/com/epam/reportportal/auth/oauth/OAuthProvider.java|48 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/oauth/OAuthProvider.java|58 col 40| Abbreviation in name 'getOAuthRestOperations' must contain no more than '1' consecutive capital letters.
src/main/java/com/epam/reportportal/auth/event/UiAuthenticationFailureEventHandler.java|51 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/event/UiAuthenticationFailureEventHandler.java|69 col 12| Abbreviation in name 'clientIP' must contain no more than '1' consecutive capital letters.
src/main/java/com/epam/reportportal/auth/event/UiAuthenticationFailureEventHandler.java|74 col 18| Abbreviation in name 'getClientIP' must contain no more than '1' consecutive capital letters.
src/main/java/com/epam/reportportal/auth/event/UiAuthenticationSuccessEventHandler.java|24 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.user.User'.
src/main/java/com/epam/reportportal/auth/event/UiAuthenticationSuccessEventHandler.java|26 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.util.PersonalProjectService'.
src/main/java/com/epam/reportportal/auth/event/UiAuthenticationSuccessEventHandler.java|56 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/store/MutableClientRegistrationRepository.java|25 col 1| Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.oauth.OAuthRegistration'.
src/main/java/com/epam/reportportal/auth/store/MutableClientRegistrationRepository.java|36 col 45| Member name 'oAuthRegistrationRepository' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]$'.
src/main/java/com/epam/reportportal/auth/store/MutableClientRegistrationRepository.java|40 col 35| Parameter name 'oAuthRegistrationRepository' must match pattern '^a-z?$'.
src/main/java/com/epam/reportportal/auth/store/MutableClientRegistrationRepository.java|54 col 38| Abbreviation in name 'findOAuthRegistrationById' must contain no more than '1' consecutive capital letters.
src/main/java/com/epam/reportportal/auth/OperationCompletionRS.java|23| First sentence of Javadoc is missing an ending period.
src/main/java/com/epam/reportportal/auth/OperationCompletionRS.java|29 col 14| Abbreviation in name 'OperationCompletionRS' must contain no more than '1' consecutive capital letters.
src/main/java/com/epam/reportportal/auth/TokenServicesFacade.java|45 col 38| Member name 'oAuth2RequestFactory' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
src/main/java/com/epam/reportportal/auth/TokenServicesFacade.java|48 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/TokenServicesFacade.java|62 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/TokenServicesFacade.java|70 col 25| Abbreviation in name 'createOAuth2Request' must contain no more than '1' consecutive capital letters.
| return new SimpleKey(); | ||
| } | ||
|
|
||
| public class LocalServiceProviderConfigurationDelegate extends LocalServiceProviderConfiguration { |
There was a problem hiding this comment.
Missing a Javadoc comment.
| private SamlUserReplicator samlUserReplicator; | ||
| private SamlServerConfiguration serviceProviderConfiguration; | ||
|
|
||
| public SamlServiceProviderBeanConfiguration( |
There was a problem hiding this comment.
Missing a Javadoc comment.
| @@ -31,17 +31,28 @@ | |||
| import com.epam.ta.reportportal.dao.IntegrationRepository; | |||
| import com.epam.ta.reportportal.dao.ServerSettingsRepository; | |||
| import com.epam.ta.reportportal.entity.ServerSettings; | |||
| import com.epam.ta.reportportal.exception.ReportPortalException; | |||
| import com.epam.ta.reportportal.ws.model.ErrorType; | |||
| import com.epam.reportportal.rules.exception.ReportPortalException; | |||
There was a problem hiding this comment.
Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ReportPortalException' import. Should be before 'com.epam.ta.reportportal.entity.ServerSettings'.
| import com.epam.ta.reportportal.exception.ReportPortalException; | ||
| import com.epam.ta.reportportal.ws.model.ErrorType; | ||
| import com.epam.reportportal.rules.exception.ReportPortalException; | ||
| import com.epam.reportportal.rules.exception.ErrorType; |
There was a problem hiding this comment.
Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.ta.reportportal.entity.ServerSettings'.
| } | ||
|
|
||
| } | ||
| @EnableOAuth2Client |
There was a problem hiding this comment.
Missing a Javadoc comment.
| }; | ||
| } | ||
|
|
||
| @Bean |
There was a problem hiding this comment.
Missing a Javadoc comment.
| import static java.util.Optional.ofNullable; | ||
|
|
||
| import com.epam.reportportal.rules.exception.ReportPortalException; | ||
| import com.epam.reportportal.rules.exception.ErrorType; |
There was a problem hiding this comment.
Wrong lexicographical order for 'com.epam.reportportal.rules.exception.ErrorType' import. Should be before 'com.epam.reportportal.rules.exception.ReportPortalException'.
| } | ||
| @Override | ||
| protected OAuth2AccessToken getToken(Authentication authentication) { | ||
| OAuth2Authentication oAuth2Authentication = ofNullable( |
| throw new Error("Error opening keystore: " + e.getCause(), e); | ||
| } | ||
| } | ||
| public static X509Certificate getCertificateByName(String certificateAlias, String trustStoreName, |
There was a problem hiding this comment.
Missing a Javadoc comment.
| throw new Error("Error opening keystore: " + e.getCause(), e); | ||
| } | ||
| } | ||
| public static PrivateKey getPrivateKey(String keyAlias, String keyPass, String trustStore, |
There was a problem hiding this comment.
Missing a Javadoc comment.
|
No description provided.