EPMRPP-87316 || Implement functionality to add Assignee and Milestone… #3644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3644 +/- ##
========================================
Coverage 60.21% 60.21%
========================================
Files 79 79
Lines 857 857
Branches 124 124
========================================
Hits 516 516
Misses 314 314
Partials 27 27 ☔ View full report in Codecov by Sentry. |
AmsterGet
requested changes
Nov 9, 2023
app/src/componentLibrary/autocompletes/singleAutocomplete/singleAutocomplete.jsx
Outdated
Show resolved
Hide resolved
… for GitLab issue by typing its name EPMRPP-87317 || Implement functionality to add Epic and Assignees for GitLab issue by typing its name
… for GitLab issue by typing its name EPMRPP-87317 || Implement functionality to add Epic and Assignees for GitLab issue by typing its name
Vadim73i
force-pushed
the
feature/autocomplete
branch
from
69ce3a2 to
6abd271
Compare
AmsterGet
requested changes
Nov 13, 2023
...components/integrations/elements/bts/btsPropertiesForIssueForm/btsPropertiesForIssueForm.jsx
Outdated
Show resolved
Hide resolved
app/src/components/fields/dynamicFieldsSection/fields/multipleAutocompleteField.jsx
Outdated
Show resolved
Hide resolved
app/src/components/fields/dynamicFieldsSection/fields/autocompleteField.jsx
Outdated
Show resolved
Hide resolved
app/src/componentLibrary/autocompletes/common/autocompleteMenu/autocompleteMenu.scss
Outdated
Show resolved
Hide resolved
app/src/componentLibrary/autocompletes/singleAutocomplete/singleAutocomplete.jsx
Outdated
Show resolved
Hide resolved
app/src/componentLibrary/autocompletes/singleAutocomplete/singleAutocomplete.jsx
Outdated
Show resolved
Hide resolved
app/src/componentLibrary/autocompletes/multipleAutocomplete/multipleAutocomplete.jsx
Outdated
Show resolved
Hide resolved
Bam6ycha
requested changes
Nov 14, 2023
EPMRPP-87317 || code review fixes - 1
EPMRPP-87317 || code review fixes - 2
EPMRPP-87317 || code review fixes - 3
|
Kudos, SonarCloud Quality Gate passed!
|
AmsterGet
approved these changes
Nov 21, 2023
Bam6ycha
reviewed
Nov 21, 2023
| const value = (inputValue || '').trim(); | ||
| const uri = getURI(value); | ||
| const requestParams = getRequestParams(value); |
There was a problem hiding this comment.
As I can see, If getRequestParams is not provided, the result of this function invocation will be undefined.
Bam6ycha
reviewed
Nov 21, 2023
Bam6ycha
reviewed
Nov 21, 2023
...components/integrations/elements/bts/btsPropertiesForIssueForm/btsPropertiesForIssueForm.jsx
Show resolved
Hide resolved
Bam6ycha
reviewed
Nov 21, 2023
Bam6ycha
reviewed
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… for GitLab issue by typing its name
EPMRPP-87317 || Implement functionality to add Epic and Assignees for GitLab issue by typing its name