Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-87330 || Service-ui Security vulnerabilities #3645

Closed

Conversation

BlazarQSO
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6bef3a0) 60.28% compared to head (31bbdff) 60.21%.
Report is 14 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3645      +/-   ##
===========================================
- Coverage    60.28%   60.21%   -0.08%     
===========================================
  Files           78       79       +1     
  Lines          856      857       +1     
  Branches       124      124              
===========================================
  Hits           516      516              
- Misses         313      314       +1     
  Partials        27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AmsterGet AmsterGet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also check is it possible to bump c3 lib version, because vulnerable d3-color is a sub dependency of it.

image

@AmsterGet
Copy link
Member

Also check the semver package as its vulnerable versions are not fully updated within this PR.

@Bam6ycha
Copy link
Contributor

Bam6ycha commented Nov 14, 2023

Please also check is it possible to bump c3 lib version, because vulnerable d3-color is a sub dependency of it.

image

The latest version of c3 depends on d3-color v 1.4.1
So, we can not fix this vulnerability

@Bam6ycha
Copy link
Contributor

Screenshot 2023-11-14 at 13 42 16

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AmsterGet
Copy link
Member

Closed in favor of #3655

@AmsterGet AmsterGet closed this Nov 17, 2023
@AmsterGet AmsterGet deleted the fix/EPMRPP-87330-service-ui-security-vulnerabilities branch November 17, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants